Bug 232843 - [GPU Process] [Filters 14/23] Apply the filter to an ImageBuffer through GraphicsContext and ImageBuffer
Summary: [GPU Process] [Filters 14/23] Apply the filter to an ImageBuffer through Grap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 231253
  Show dependency tree / graph
 
Reported: 2021-11-08 13:18 PST by Said Abou-Hallawa
Modified: 2021-11-29 21:36 PST (History)
21 users (show)

See Also:

Attachments
Patch (38.41 KB, patch)
2021-11-27 13:43 PST, Said Abou-Hallawa 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (39.01 KB, patch)
2021-11-27 14:16 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (36.45 KB, patch)
2021-11-27 19:14 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (35.47 KB, patch)
2021-11-27 21:14 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (37.52 KB, patch)
2021-11-28 11:50 PST, Said Abou-Hallawa 		heycam: review+
Details | Formatted Diff | Diff
Patch (37.43 KB, patch)
2021-11-28 19:41 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2021-11-08 13:18:54 PST 
This will make it possible to record applying the filter for GPUProcess.
Comment 1 Radar WebKit Bug Importer 2021-11-15 13:23:10 PST 
<rdar://problem/85426291>
Comment 2 Said Abou-Hallawa 2021-11-27 13:43:08 PST 
Created attachment 445223 [details]
Patch
Comment 3 Said Abou-Hallawa 2021-11-27 14:16:50 PST 
Created attachment 445224 [details]
Patch
Comment 4 Said Abou-Hallawa 2021-11-27 19:14:35 PST 
Created attachment 445228 [details]
Patch
Comment 5 Said Abou-Hallawa 2021-11-27 21:14:32 PST 
Created attachment 445231 [details]
Patch
Comment 6 Said Abou-Hallawa 2021-11-28 11:50:02 PST 
Created attachment 445240 [details]
Patch
Comment 7 Said Abou-Hallawa 2021-11-28 19:41:03 PST 
Created attachment 445247 [details]
Patch
Comment 8 Said Abou-Hallawa 2021-11-28 19:53:51 PST 
Comment on attachment 445240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445240&action=review

> Source/WebCore/rendering/CSSFilter.cpp:401
> +    effect->transformResultColorSpace(DestinationColorSpace::SRGB());

This call is not needed since the caller which is Filter::apply() will transform the returned FilterImage to sRGB. This is fixed in the latest patch.
Comment 9 EWS 2021-11-28 22:08:34 PST 
Committed r286203 (244585@main): <https://commits.webkit.org/244585@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445247 [details].