| Summary: | Fix consistency issues with localized strings, and regenerate localizable.strings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
| Component: | WebCore Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, cgarcia, darin, hi, megan_gardner, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=233483 | ||||||||
| Bug Depends on: | 218879, 226361, 226888, 232462 | ||||||||
| Bug Blocks: | 232686 | ||||||||
| Attachments: |
|
||||||||
|
Description
David Kilzer (:ddkilzer)
2021-11-02 15:17:33 PDT
Created attachment 443138 [details]
Patch v1
Comment on attachment 443138 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=443138&action=review > Source/WebCore/en.lproj/Localizable.strings:38 > +"%@ Easy (text track)" = "%@ Easy Reader"; this should actually probably be fixed in the corresponding code 😅 Comment on attachment 443138 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=443138&action=review >> Source/WebCore/en.lproj/Localizable.strings:38 >> +"%@ Easy (text track)" = "%@ Easy Reader"; > > this should actually probably be fixed in the corresponding code 😅 Ah, I wasn't sure which way to go. I will change the code to match the format string. Thanks! Comment on attachment 443138 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=443138&action=review > Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm:280 > - return [NSString localizedStringWithFormat:WEB_UI_NSSTRING(@"Use no more than %d character(s)", @"Validation message for form control elements with a value shorter than maximum allowed length"), maxLength]; > + return formatLocalizedString(WEB_UI_CFSTRING("Use no more than %d character(s)", "Validation message for form control elements with a value shorter than maximum allowed length"), maxLength); This caused a regression, so I'm going to remove it from this patch. (It will appear in a follow-up patch, though.) Created attachment 443143 [details]
Patch v2
Comment on attachment 443143 [details]
Patch v2
Thanks Megan!
Committed r285234 (243855@main): <https://commits.webkit.org/243855@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443143 [details]. |