| Summary: | Have ImageDiff print the diff image when any pixel is different | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | gsnedders, jbedard, mrobinson, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 232225, 232288 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2021-10-25 20:47:59 PDT
Created attachment 442460 [details]
Patch
Comment on attachment 442460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442460&action=review I like where this is heading. > Tools/Scripts/webkitpy/port/image_diff.py:133 > + if diff_output: I wonder if this should print some sort of warning is there is no diff_output? Committed r284870 (243547@main): <https://commits.webkit.org/243547@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442460 [details]. |