Bug 232294

Summary: Have ImageDiff print the diff image when any pixel is different
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: gsnedders, jbedard, mrobinson, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 232225, 232288    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2021-10-25 20:47:59 PDT
Have ImageDiff print the diff image when any pixel is different
Attachments
Patch (12.83 KB, patch)
2021-10-25 20:53 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-10-25 20:53:36 PDT
Created attachment 442460 [details] Patch
Martin Robinson
Comment 2 2021-10-26 02:14:41 PDT
Comment on attachment 442460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442460&action=review I like where this is heading. > Tools/Scripts/webkitpy/port/image_diff.py:133 > + if diff_output: I wonder if this should print some sort of warning is there is no diff_output?
EWS
Comment 3 2021-10-26 08:55:56 PDT
Committed r284870 (243547@main): <https://commits.webkit.org/243547@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442460 [details].
Radar WebKit Bug Importer
Comment 4 2021-10-26 08:56:21 PDT
<rdar://problem/84665305>
Note You need to log in before you can comment on or make changes to this bug.