Bug 232288

Summary: Don't run ImageDiff a second time to generate diff images
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, gsnedders, jbedard, mrobinson, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 232225    
Bug Blocks: 232294    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Simon Fraser (smfr) 2021-10-25 17:28:55 PDT 
Don't run ImageDiff a second time to generate diff images
Comment 1 Simon Fraser (smfr) 2021-10-25 17:32:09 PDT 
Created attachment 442441 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-10-25 19:51:16 PDT 
Created attachment 442456 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-10-25 20:21:34 PDT 
Created attachment 442459 [details]
Patch
Comment 4 Martin Robinson 2021-10-26 01:38:56 PDT 
Comment on attachment 442459 [details]
Patch

This is great and hopefully it speeds up tests a bit.
Comment 5 EWS 2021-10-26 08:04:20 PDT 
Committed r284866 (243543@main): <https://commits.webkit.org/243543@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442459 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-26 08:05:21 PDT 
<rdar://problem/84663717>