Summary: | Rename {checked,dynamic}_ns_cast<> to {checked,dynamic}_objc_cast<> | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Component: | Web Template Framework | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | annulen, benjamin, bfulgham, cdumez, changseok, cmarcelo, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, pdr, philipj, ryuan.choi, sergio, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=230467 | ||||||||
Bug Depends on: | 139893, 139915, 230227 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2021-09-20 14:01:28 PDT
Created attachment 438729 [details]
Patch v1
Created attachment 438730 [details] Patch v1 (showing changes in renamed files) This is the same as "Patch v1" (Attachment #438729 [details]), but only shows changes in renamed files. Much easier to review, but I'm not sure if EWS will handle it. (In reply to David Kilzer (:ddkilzer) from comment #3) > Created attachment 438730 [details] > Patch v1 (showing changes in renamed files) > > This is the same as "Patch v1" (Attachment #438729 [details]), but only > shows changes in renamed files. > > Much easier to review, but I'm not sure if EWS will handle it. Hmmm...I guess svn-apply-patch will handle this just fine. We should probably change svn-create-patch to use the pure git patch for renamed files to make them easier to review. Review ping Comment on attachment 438730 [details]
Patch v1 (showing changes in renamed files)
r=me
Committed r282844 (241975@main): <https://commits.webkit.org/241975@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438730 [details]. |