Bug 230508

Summary:

Rename {checked,dynamic}_ns_cast<> to {checked,dynamic}_objc_cast<>

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Web Template Framework

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, benjamin, bfulgham, cdumez, changseok, cmarcelo, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, pdr, philipj, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=230467

Bug Depends on:

139893, 139915, 230227

Bug Blocks:

Attachments:

Description	Flags
Patch v1	none
Patch v1 (showing changes in renamed files)	none

David Kilzer (:ddkilzer)

Reported 2021-09-20 14:01:28 PDT

Rename {checked,dynamic}_ns_cast<> to {checked,dynamic}_objc_cast<>. In Bug 230406, Darin writes: > Did you see my comment about dynamic_objc_cast? I think I prefer that name to dynamic_ns_cast.

Attachments
Patch v1 (44.56 KB, patch) 2021-09-20 14:29 PDT, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
Patch v1 (showing changes in renamed files) (36.68 KB, patch) 2021-09-20 14:31 PDT, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-09-20 14:01:55 PDT

<rdar://problem/83323145>

David Kilzer (:ddkilzer)

Comment 2 2021-09-20 14:29:51 PDT

Created attachment 438729 [details] Patch v1

David Kilzer (:ddkilzer)

Comment 3 2021-09-20 14:31:58 PDT

Created attachment 438730 [details] Patch v1 (showing changes in renamed files) This is the same as "Patch v1" (Attachment #438729 [details]), but only shows changes in renamed files. Much easier to review, but I'm not sure if EWS will handle it.

David Kilzer (:ddkilzer)

Comment 4 2021-09-20 14:35:45 PDT

(In reply to David Kilzer (:ddkilzer) from comment #3) > Created attachment 438730 [details] > Patch v1 (showing changes in renamed files) > > This is the same as "Patch v1" (Attachment #438729 [details]), but only > shows changes in renamed files. > > Much easier to review, but I'm not sure if EWS will handle it. Hmmm...I guess svn-apply-patch will handle this just fine. We should probably change svn-create-patch to use the pure git patch for renamed files to make them easier to review.

David Kilzer (:ddkilzer)

Comment 5 2021-09-21 08:18:44 PDT

Review ping

Brent Fulgham

Comment 6 2021-09-21 14:36:57 PDT

Comment on attachment 438730 [details] Patch v1 (showing changes in renamed files) r=me

EWS

Comment 7 2021-09-21 15:13:31 PDT

Committed r282844 (241975@main): <https://commits.webkit.org/241975@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438730 [details].

Note You need to log in before you can comment on or make changes to this bug.