Bug 230449

Summary: [Cocoa] Hook up palettes to CoreText
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jonlee, koivisto, macpherson, menard, mmaxfield, simon.fraser, thorton, webkit-bug-importer, youennf, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 230394, 230447, 230592    
Bug Blocks: 230446    
Attachments:
Description Flags
Needs tests
none
Test
none
Test font
none
Patch simon.fraser: review+

Description Myles C. Maxfield 2021-09-18 14:14:49 PDT 
... in preparePlatformFont()
Comment 1 Myles C. Maxfield 2021-09-18 23:15:11 PDT 
Created attachment 438579 [details]
Needs tests
Comment 2 Myles C. Maxfield 2021-09-18 23:24:12 PDT 
Created attachment 438581 [details]
Test
Comment 3 Myles C. Maxfield 2021-09-18 23:24:51 PDT 
Created attachment 438582 [details]
Test font
Comment 4 Radar WebKit Bug Importer 2021-09-21 01:08:51 PDT 
<rdar://problem/83343475>
Comment 5 Myles C. Maxfield 2021-09-21 22:19:11 PDT 
Created attachment 438920 [details]
Patch
Comment 6 EWS Watchlist 2021-09-21 22:20:21 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 7 Simon Fraser (smfr) 2021-09-22 21:17:34 PDT 
Comment on attachment 438920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438920&action=review

> Source/WebCore/css/CSSFontSelector.cpp:350
> +    auto fontPaletteValues = lookupFontPaletteValues(familyName, fontDescription);

auto&
Comment 8 Myles C. Maxfield 2021-09-22 21:52:16 PDT 
Committed r282922 (242036@main): <https://commits.webkit.org/242036@main>