Bug 230449

Summary: [Cocoa] Hook up palettes to CoreText
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jonlee, koivisto, macpherson, menard, mmaxfield, simon.fraser, thorton, webkit-bug-importer, youennf, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 230394, 230447, 230592    
Bug Blocks: 230446    
Attachments:
Description Flags
Needs tests
none
Test
none
Test font
none
Patch simon.fraser: review+

Myles C. Maxfield
Reported 2021-09-18 14:14:49 PDT
... in preparePlatformFont()
Attachments
Needs tests (66.66 KB, patch)
2021-09-18 23:15 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Test (1.09 KB, text/html)
2021-09-18 23:24 PDT, Myles C. Maxfield 		no flags
Details
Test font (5.36 KB, application/zip)
2021-09-18 23:24 PDT, Myles C. Maxfield 		no flags
Details
Patch (38.56 KB, patch)
2021-09-21 22:19 PDT, Myles C. Maxfield 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-09-18 23:15:11 PDT
Created attachment 438579 [details] Needs tests
Myles C. Maxfield
Comment 2 2021-09-18 23:24:12 PDT
Created attachment 438581 [details] Test
Myles C. Maxfield
Comment 3 2021-09-18 23:24:51 PDT
Created attachment 438582 [details] Test font
Radar WebKit Bug Importer
Comment 4 2021-09-21 01:08:51 PDT
<rdar://problem/83343475>
Myles C. Maxfield
Comment 5 2021-09-21 22:19:11 PDT
Created attachment 438920 [details] Patch
EWS Watchlist
Comment 6 2021-09-21 22:20:21 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Simon Fraser (smfr)
Comment 7 2021-09-22 21:17:34 PDT
Comment on attachment 438920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438920&action=review > Source/WebCore/css/CSSFontSelector.cpp:350 > + auto fontPaletteValues = lookupFontPaletteValues(familyName, fontDescription); auto&
Myles C. Maxfield
Comment 8 2021-09-22 21:52:16 PDT
Committed r282922 (242036@main): <https://commits.webkit.org/242036@main>
Note You need to log in before you can comment on or make changes to this bug.