Bug 230592 - Add FontCreationContext
Summary: Add FontCreationContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 230446 230449
  Show dependency tree / graph
 
Reported: 2021-09-21 19:00 PDT by Myles C. Maxfield
Modified: 2021-09-21 21:06 PDT (History)
13 users (show)

See Also:

Attachments
Patch (56.77 KB, patch)
2021-09-21 19:05 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (59.46 KB, patch)
2021-09-21 19:18 PDT, Myles C. Maxfield 		zalan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (65.76 KB, patch)
2021-09-21 20:31 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-09-21 19:00:57 PDT 
Add FontCreationContext
Comment 1 Myles C. Maxfield 2021-09-21 19:05:41 PDT 
Created attachment 438903 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-09-21 19:06:20 PDT 
<rdar://problem/83379889>
Comment 3 Myles C. Maxfield 2021-09-21 19:18:34 PDT 
Created attachment 438906 [details]
Patch
Comment 4 zalan 2021-09-21 20:05:34 PDT 
Comment on attachment 438906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438906&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:579
> -    auto attributes = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 2, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
> +    auto attributes = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));

TIL Pass 0 to specify that the maximum capacity is not limited.
Comment 5 Myles C. Maxfield 2021-09-21 20:31:39 PDT 
Created attachment 438910 [details]
Patch for committing
Comment 6 Myles C. Maxfield 2021-09-21 20:33:20 PDT 
Comment on attachment 438906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438906&action=review

>> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:579
>> +    auto attributes = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
> 
> TIL Pass 0 to specify that the maximum capacity is not limited.

❤️
Comment 7 Myles C. Maxfield 2021-09-21 21:06:24 PDT 
Committed r282863 (241994@main): <https://commits.webkit.org/241994@main>