Bug 230447 - Push font-palette-values data into CSSFontSelector
Summary: Push font-palette-values data into CSSFontSelector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on: 230337 230544 230546
Blocks: 230446 230449
  Show dependency tree / graph
 
Reported: 2021-09-18 14:13 PDT by Myles C. Maxfield
Modified: 2021-09-21 13:17 PDT (History)
10 users (show)

See Also:

Attachments
Patch (22.14 KB, patch)
2021-09-18 23:17 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (7.15 KB, patch)
2021-09-21 02:01 PDT, Myles C. Maxfield 		koivisto: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-09-18 14:13:10 PDT 
... And move the values of the color-override / base-palette descriptors into types that can be accessed from platform/
Comment 1 Myles C. Maxfield 2021-09-18 23:17:59 PDT 
Created attachment 438580 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-09-21 01:15:45 PDT 
<rdar://problem/83343615>
Comment 3 Myles C. Maxfield 2021-09-21 02:01:52 PDT 
Created attachment 438795 [details]
Patch
Comment 4 Antti Koivisto 2021-09-21 02:05:59 PDT 
Comment on attachment 438795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438795&action=review

> Source/WebCore/css/CSSFontSelector.h:148
> +struct CSSFontSelector::PaletteKey {

Couldn't this just be std::pair<AtomString, AtomString>?

> Source/WebCore/css/CSSFontSelector.h:178
> +struct CSSFontSelector::PaletteKeyHash {

And avoid all this.
Comment 5 Myles C. Maxfield 2021-09-21 02:21:57 PDT 
Committed r282807 (241939@main): <https://commits.webkit.org/241939@main>
Comment 6 WebKit Commit Bot 2021-09-21 03:57:06 PDT 
Re-opened since this is blocked by bug 230544
Comment 7 Myles C. Maxfield 2021-09-21 12:04:53 PDT 
Reopening.
Comment 8 Myles C. Maxfield 2021-09-21 13:17:56 PDT 
Committed r282838 (241969@main): <https://commits.webkit.org/241969@main>