RESOLVED FIXED 230447
Push font-palette-values data into CSSFontSelector 
https://bugs.webkit.org/show_bug.cgi?id=230447
Summary Push font-palette-values data into CSSFontSelector
Myles C. Maxfield
Reported 2021-09-18 14:13:10 PDT
... And move the values of the color-override / base-palette descriptors into types that can be accessed from platform/
Attachments
Patch (22.14 KB, patch)
2021-09-18 23:17 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (7.15 KB, patch)
2021-09-21 02:01 PDT, Myles C. Maxfield 		koivisto: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-09-18 23:17:59 PDT
Created attachment 438580 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-09-21 01:15:45 PDT
<rdar://problem/83343615>
Myles C. Maxfield
Comment 3 2021-09-21 02:01:52 PDT
Created attachment 438795 [details] Patch
Antti Koivisto
Comment 4 2021-09-21 02:05:59 PDT
Comment on attachment 438795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438795&action=review > Source/WebCore/css/CSSFontSelector.h:148 > +struct CSSFontSelector::PaletteKey { Couldn't this just be std::pair<AtomString, AtomString>? > Source/WebCore/css/CSSFontSelector.h:178 > +struct CSSFontSelector::PaletteKeyHash { And avoid all this.
Myles C. Maxfield
Comment 5 2021-09-21 02:21:57 PDT
Committed r282807 (241939@main): <https://commits.webkit.org/241939@main>
WebKit Commit Bot
Comment 6 2021-09-21 03:57:06 PDT
Re-opened since this is blocked by bug 230544
Myles C. Maxfield
Comment 7 2021-09-21 12:04:53 PDT
Reopening.
Myles C. Maxfield
Comment 8 2021-09-21 13:17:56 PDT
Committed r282838 (241969@main): <https://commits.webkit.org/241969@main>
Note You need to log in before you can comment on or make changes to this bug.