Bug 230394 – Parsing support for font-palette

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Parsing support for font-palette

[Myles C. Maxfield]

Created attachment 438453 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Myles C. Maxfield]

Created attachment 438455 [details]
Patch

[Myles C. Maxfield]

Created attachment 438552 [details]
Patch

[Myles C. Maxfield]

Created attachment 438553 [details]
Patch

[Myles C. Maxfield]

Created attachment 438554 [details]
Patch

[Myles C. Maxfield]

Created attachment 438556 [details]
Patch

[Myles C. Maxfield]

Created attachment 438563 [details]
Patch

[Myles C. Maxfield]

Created attachment 438790 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/83343658>

[Myles C. Maxfield]

Comment on attachment 438790 [details]
Patch

Simon says to use option 2 instead.

[Myles C. Maxfield]

Created attachment 438852 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 438852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438852&action=review

> Source/WebCore/platform/graphics/FontCache.h:160
> +            if (!m_rareData && !other.m_rareData)
> +                return true;
> +            return m_rareData && other.m_rareData && *m_rareData == *other.m_rareData;

arePointingToEqualData()?

> Source/WebCore/platform/graphics/FontPalette.h:37
> +        return type == other.type;

Shouldn't this compare the identifier if custom?

> Source/WebCore/platform/graphics/FontPalette.h:45
> +    enum class Type {

: unit8_t?

Won't help with padding here though, but it might shrink IPC.

> LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:6
> +FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 394
> +FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 394
> +FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 394
> +FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 394

You'll need iOS results for these.

[Myles C. Maxfield]

Created attachment 438867 [details]
Patch for committing

[Simon Fraser (smfr)]

Comment on attachment 438867 [details]
Patch for committing

View in context: https://bugs.webkit.org/attachment.cgi?id=438867&action=review

> Source/WebCore/platform/graphics/FontCache.h:161
> +            && m_locale == other.m_locale) {
> +            if (!m_rareData && !other.m_rareData)
> +                return true;
> +            return arePointingToEqualData(m_rareData, other.m_rareData);

Why can't this be:

&& m_locale == other.m_locale
&& arePointingToEqualData(m_rareData, other.m_rareData))
  return true

[Myles C. Maxfield]

Comment on attachment 438867 [details]
Patch for committing

View in context: https://bugs.webkit.org/attachment.cgi?id=438867&action=review

>> Source/WebCore/platform/graphics/FontCache.h:161
>> +            return arePointingToEqualData(m_rareData, other.m_rareData);
> 
> Why can't this be:
> 
> && m_locale == other.m_locale
> && arePointingToEqualData(m_rareData, other.m_rareData))
>   return true

Whoops :(

[Myles C. Maxfield]

Committed r282851 (241982@main): <https://commits.webkit.org/241982@main>

[Myles C. Maxfield]

*** Bug 230566 has been marked as a duplicate of this bug. ***