Summary: | Make text-decoration CSS property spec-compliant | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||||||
Component: | CSS | Assignee: | Matthieu Dubet <m_dubet> | ||||||||||||
Status: | NEW --- | ||||||||||||||
Severity: | Normal | CC: | aboxhall, alystair, andresg_22, apinheiro, brandonstewart, cfleizach, changseok, chriskirknielsen+wkbugs, clopez, dino, dmazzoni, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, jcraig, jdiggs, joepeck, karlcow, kizmarh, kondapallykalyan, macpherson, martin, menard, mifenton, mmaxfield, ntim, obrufau, pdr, sabouhallawa, samuel_white, schenney, sergio, simon.fraser, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | BrowserCompat, InRadar, WebExposed | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=239069 https://bugs.webkit.org/show_bug.cgi?id=213554 https://bugs.webkit.org/show_bug.cgi?id=135353 https://bugs.webkit.org/show_bug.cgi?id=237175 |
||||||||||||||
Bug Depends on: | 232729, 233154, 237175 | ||||||||||||||
Bug Blocks: | 58491 | ||||||||||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2021-09-08 22:29:17 PDT
Created attachment 442400 [details]
Patch
Created attachment 446721 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess (In reply to Tim Nguyen (:ntim) from comment #3) > Created attachment 446721 [details] > Patch I'm curious what's blocking this? Been patiently waiting for a few years for something along these lines to land to allow for text-decoration /w thickness without a prefix. Thanks! (In reply to Lorin H from comment #5) > (In reply to Tim Nguyen (:ntim) from comment #3) > > Created attachment 446721 [details] > > Patch > > I'm curious what's blocking this? Been patiently waiting for a few years for > something along these lines to land to allow for text-decoration /w > thickness without a prefix. Thanks! editing/ tests are failing unfortunately. Needs someone familiar with that code to take a look at it. Everything else in the patch works reasonably well however. Bug 237175 made it a shorthand, there are still some things to do to make it spec compliant (see attached patch). Some things remaining to do: - Remove -webkit-text-decoration, or make it an alias of text-decoration. - For some reason, text-decoration-thickness is inherited, it shouldn't be according to the spec. - text-decoration should parse and serialize values for any longhand, not just text-decoration-line. In the reland of bug 237175 I made text-decoration be a shorthand of only text-decoration-line. It should be a shorthand of all the text-decoration-* longhands. This will probably need changing the editing code like in https://commits.webkit.org/r290756 *** Bug 243865 has been marked as a duplicate of this bug. *** Created attachment 462063 [details]
Patch
Created attachment 462065 [details]
Patch
Created attachment 463517 [details]
Patch with editing changes
This is a patch with Oriol's editing changes (that were reverted due to perf regression). For simplicity, I'll deal with editing in a separate patch, so we can land this easily.
I might include editing changes after all, but restrict certain work to text-decoration to avoid perf regressions. Pull request: https://github.com/WebKit/WebKit/pull/6466 *** Bug 259428 has been marked as a duplicate of this bug. *** Pull request: https://github.com/WebKit/WebKit/pull/23121 |