RESOLVED FIXED 213554
Child text-decoration-thickness and text-underline-offset override parent decorating boxes' values 
https://bugs.webkit.org/show_bug.cgi?id=213554
Summary Child text-decoration-thickness and text-underline-offset override parent dec...
Dominik Röttsches (drott)
Reported 2020-06-24 05:44:55 PDT
Created attachment 402640 [details] Offset nesting test In Safari release, and Safari TP, the current child node's text-decoration-thickness and text-underline-offset always override all previously defined text-decoration-thickness and text-underline-offset properties of parent elements / decorating boxes. While working on Chromium's text-decoration-thickness and text-underline-offset, I noticed these discrepancies when writing a WPT test. Example test cases attached and available at: http://roettsch.es/thickness-nesting.html http://roettsch.es/offset-nesting.html Actual: WebKit paints offset underlines and thickness-defined underline all at the same offset / thickness. Expected: Decorations should be stacked and the individual thickness and offset properties should be adhered too.
Attachments
Offset nesting test (2.09 KB, text/html)
2020-06-24 05:44 PDT, Dominik Röttsches (drott) 		no flags
Details
Thickness nesting test (2.17 KB, text/html)
2020-06-24 05:45 PDT, Dominik Röttsches (drott) 		no flags
Details
Offset nesting actual (79.87 KB, image/png)
2020-06-24 05:47 PDT, Dominik Röttsches (drott) 		no flags
Details
Offset nesting expected (90.43 KB, image/png)
2020-06-24 05:47 PDT, Dominik Röttsches (drott) 		no flags
Details
Thickness nesting actual (86.51 KB, image/png)
2020-06-24 05:47 PDT, Dominik Röttsches (drott) 		no flags
Details
Thickness nesting expected (80.37 KB, image/png)
2020-06-24 05:47 PDT, Dominik Röttsches (drott) 		no flags
Details
not-so-thick-underline (8.63 KB, image/png)
2024-11-12 16:44 PST, zalan 		no flags
Details
text-decoration-thickness-nesting-manual -pass (173.18 KB, image/png)
2024-11-12 20:41 PST, zalan 		no flags
Details
Patch (3.02 KB, patch)
2024-11-13 06:07 PST, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (5.99 KB, patch)
2024-11-13 09:54 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1 2020-06-24 05:45:11 PDT
Created attachment 402642 [details] Thickness nesting test
Dominik Röttsches (drott)
Comment 2 2020-06-24 05:47:13 PDT
Created attachment 402643 [details] Offset nesting actual
Dominik Röttsches (drott)
Comment 3 2020-06-24 05:47:30 PDT
Created attachment 402644 [details] Offset nesting expected
Dominik Röttsches (drott)
Comment 4 2020-06-24 05:47:44 PDT
Created attachment 402645 [details] Thickness nesting actual
Dominik Röttsches (drott)
Comment 5 2020-06-24 05:47:56 PDT
Created attachment 402646 [details] Thickness nesting expected
Dominik Röttsches (drott)
Comment 6 2020-06-24 05:48:52 PDT
Potentially related to issue 203528.
Radar WebKit Bug Importer
Comment 7 2020-06-24 09:39:22 PDT
<rdar://problem/64705955>
zalan
Comment 9 2024-11-12 16:44:27 PST
Created attachment 473212 [details] not-so-thick-underline text-decoration-thickness-nesting-manual.html seems to be about ink overflow as with small enough values, it all looks ok.
zalan
Comment 10 2024-11-12 20:41:20 PST
Created attachment 473214 [details] text-decoration-thickness-nesting-manual -pass Actually the missing underline in text-decoration-thickness-nesting-manual.html is caused by a "feature" in our skip underline implementation.
zalan
Comment 11 2024-11-13 06:07:44 PST
Created attachment 473217 [details] Patch
zalan
Comment 12 2024-11-13 06:08:18 PST
(needs test case)
zalan
Comment 13 2024-11-13 09:54:50 PST
Created attachment 473219 [details] [fast-cq]Patch
EWS
Comment 14 2024-11-15 07:46:59 PST
Committed 286639@main (6acc886e4f70): <https://commits.webkit.org/286639@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 473219 [details].
Note You need to log in before you can comment on or make changes to this bug.