Bug 135353 - Use CSS3 Decorating Box concept to determine thickness for text decorations
Summary: Use CSS3 Decorating Box concept to determine thickness for text decorations
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 130657 167331 190772 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-28 14:19 PDT by Myles C. Maxfield
Modified: 2022-07-16 20:18 PDT (History)
11 users (show)

See Also:

Attachments
Patch (8.65 KB, patch)
2014-07-28 14:37 PDT, Myles C. Maxfield 		mmaxfield: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-07-28 14:19:53 PDT 
Use CSS3 Decorating Box concept to determine thickness for text decorations
Comment 1 Myles C. Maxfield 2014-07-28 14:37:46 PDT 
Created attachment 235617 [details]
Patch
Comment 2 Myles C. Maxfield 2014-07-28 14:40:11 PDT 
<rdar://problem/15044440>
Comment 3 Myles C. Maxfield 2014-09-08 19:59:40 PDT 
Comment on attachment 235617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235617&action=review

> Source/WebCore/rendering/InlineTextBox.h:187
> +    const InlineFlowBox* m_decoratingBox;

This blows up the size by a significant amount. See if the performance hit of computing this when it is needed is too high.
Comment 4 Myles C. Maxfield 2022-04-04 14:22:28 PDT 
*** Bug 167331 has been marked as a duplicate of this bug. ***
Comment 5 Myles C. Maxfield 2022-04-04 14:23:03 PDT 
*** Bug 190772 has been marked as a duplicate of this bug. ***
Comment 6 Myles C. Maxfield 2022-07-16 20:18:05 PDT 
*** Bug 130657 has been marked as a duplicate of this bug. ***