Bug 224716

Summary: REGRESSION(r275655): Introduced many debug build warnings
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKit2Assignee: Philippe Normand <pnormand>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: darin, kkinnunen
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224269
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Description Philippe Normand 2021-04-17 03:45:02 PDT 
https://bugs.webkit.org/show_bug.cgi?id=224269#c4
Comment 1 Philippe Normand 2021-04-17 03:58:36 PDT 
Created attachment 426330 [details]
Patch
Comment 2 Philippe Normand 2021-04-17 04:11:57 PDT 
Created attachment 426331 [details]
Patch
Comment 3 Darin Adler 2021-04-17 17:49:01 PDT 
Comment on attachment 426331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426331&action=review

> Source/WebKit/ChangeLog:8
> +        PRIu64 is the most portable format specifier for unsigned long long.

This comment is inaccurate.

PRIu64 is the correct format specifier for uint64_t.

If the type is actually "unsigned long long" then PRIu64 is not correct.
Comment 4 Kimmo Kinnunen 2021-04-18 23:16:26 PDT 
I tried to fix these in bug 224335 already on 2021-04-12 (or did I fail landing or was it reverted)?
Comment 5 Kimmo Kinnunen 2021-04-18 23:24:32 PDT 
Yep, I failed to land it but Darin then landed it.
Philippe, Darin, sorry for the trouble..
Comment 6 Philippe Normand 2021-04-19 00:38:48 PDT 

*** This bug has been marked as a duplicate of bug 224335 ***