Bug 224335

Summary: Unhandled IPC messages should use correct format with the decoder.destinationID() ASSERT message
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebKit2Assignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, kkinnunen, koivisto, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 224269    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Kimmo Kinnunen
Reported 2021-04-08 12:06:13 PDT
Comment # 4 on bug 224269 from Darin Adler Comment on attachment 425357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425357&action=review > Source/WebKit/Scripts/webkit/messages.py:951 > + result.append(' ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled stream message %s to %llu", description(decoder.messageName()), decoder.destinationID());\n') These are not quite right. Nothing guarantees that destinationID() is an unsigned long long. We need to use PRIu64 (not sure I got that right) instead of %llu.
Attachments
Patch (14.30 KB, patch)
2021-04-12 00:12 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-04-12 00:12:57 PDT
Created attachment 425720 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-04-15 12:07:42 PDT
<rdar://problem/76716374>
EWS
Comment 3 2021-04-17 21:47:57 PDT
Committed r276221 (236703@main): <https://commits.webkit.org/236703@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425720 [details].
Philippe Normand
Comment 4 2021-04-19 00:38:48 PDT
*** Bug 224716 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.