Bug 224269

Summary: Difficult to understand which IPC message caused an ASSERT due to being not handled
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebKit2Assignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ddkilzer, kkinnunen, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224716
Bug Depends on:    
Bug Blocks: 224335    
Attachments:
Description Flags
Patch none

Description Kimmo Kinnunen 2021-04-06 23:10:25 PDT 
Difficult to understand which IPC message caused an ASSERT due to being not handled

The assert should print the message name
Comment 1 Kimmo Kinnunen 2021-04-06 23:12:12 PDT 
Created attachment 425357 [details]
Patch
Comment 2 EWS 2021-04-08 01:58:29 PDT 
Committed r275655: <https://commits.webkit.org/r275655>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425357 [details].
Comment 3 Radar WebKit Bug Importer 2021-04-08 01:59:14 PDT 
<rdar://problem/76389887>
Comment 4 Darin Adler 2021-04-08 10:39:36 PDT 
Comment on attachment 425357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425357&action=review

> Source/WebKit/Scripts/webkit/messages.py:951
> +            result.append('    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled stream message %s to %llu", description(decoder.messageName()), decoder.destinationID());\n')

These are not quite right. Nothing guarantees that destinationID() is an unsigned long long. We need to use PRIu64 (not sure I got that right) instead of %llu.
Comment 5 Philippe Normand 2021-04-11 03:03:46 PDT 
PRIu64 is the right specifier here indeed.