Summary: | [GPUP] Implement SourceBufferPrivateRemote::bufferFull() | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peng Liu <peng.liu6> | ||||||||||
Component: | Media | Assignee: | Peng Liu <peng.liu6> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Other | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 224136, 224848, 224891 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Peng Liu
2021-04-02 16:21:47 PDT
Created attachment 426307 [details]
WIP patch
Created attachment 426484 [details]
Patch
Created attachment 426487 [details]
Fix build failures
Comment on attachment 426484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426484&action=review > Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:212 > + MediaPlayerFactorySupport::callRegisterMediaEngine(MockMediaPlayerMediaSource::registerMediaEngine); It would probably be better to have this in media-specific code. Maybe in the RemoteMediaPlayerManagerProxy constructor? > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:689 > + if (m_remoteEngineIdentifier == MediaPlayerEnums::MediaEngineIdentifier::AVFoundationMSE || m_remoteEngineIdentifier == MediaPlayerEnums::MediaEngineIdentifier::MockMSE) { Nit: something like an "isMSE()" method that checks the identifier would be cleaner and more future proof. Comment on attachment 426487 [details]
Fix build failures
r=me once the bots are happy
I am going to fix the test issues in bug 225367. Created attachment 427710 [details]
[fast-cq] Patch
Committed r277003 (237323@main): <https://commits.webkit.org/237323@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427710 [details]. |