Bug 224139

Summary: [GPUP] Implement SourceBufferPrivateRemote::bufferFull()
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 224136, 224848, 224891    
Bug Blocks:    
Attachments:
Description Flags
WIP patch
none
Patch
ews-feeder: commit-queue-
Fix build failures
none
[fast-cq] Patch none

Peng Liu
Reported 2021-04-02 16:21:47 PDT
The patch for bug 224136 will enable the code using SourceBufferPrivate::bufferFull() for Cocoa ports. We need to add the function implementation in SourceBufferPrivateRemote in order to support the "Media in GPU Process" scenario.
Attachments
WIP patch (13.43 KB, patch)
2021-04-16 18:30 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Patch (28.61 KB, patch)
2021-04-19 15:50 PDT, Peng Liu 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Fix build failures (28.42 KB, patch)
2021-04-19 16:11 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch (9.83 KB, patch)
2021-05-04 16:19 PDT, Peng Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-04-06 13:00:27 PDT
<rdar://problem/76280442>
Peng Liu
Comment 2 2021-04-16 18:30:48 PDT
Created attachment 426307 [details] WIP patch
Peng Liu
Comment 3 2021-04-19 15:50:26 PDT
Created attachment 426484 [details] Patch
Peng Liu
Comment 4 2021-04-19 16:11:16 PDT
Created attachment 426487 [details] Fix build failures
Eric Carlson
Comment 5 2021-04-19 16:26:12 PDT
Comment on attachment 426484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426484&action=review > Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:212 > + MediaPlayerFactorySupport::callRegisterMediaEngine(MockMediaPlayerMediaSource::registerMediaEngine); It would probably be better to have this in media-specific code. Maybe in the RemoteMediaPlayerManagerProxy constructor? > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:689 > + if (m_remoteEngineIdentifier == MediaPlayerEnums::MediaEngineIdentifier::AVFoundationMSE || m_remoteEngineIdentifier == MediaPlayerEnums::MediaEngineIdentifier::MockMSE) { Nit: something like an "isMSE()" method that checks the identifier would be cleaner and more future proof.
Eric Carlson
Comment 6 2021-04-19 16:26:35 PDT
Comment on attachment 426487 [details] Fix build failures r=me once the bots are happy
Peng Liu
Comment 7 2021-05-04 14:41:19 PDT
I am going to fix the test issues in bug 225367.
Peng Liu
Comment 8 2021-05-04 16:19:09 PDT
Created attachment 427710 [details] [fast-cq] Patch
EWS
Comment 9 2021-05-04 22:41:40 PDT
Committed r277003 (237323@main): <https://commits.webkit.org/237323@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427710 [details].
Note You need to log in before you can comment on or make changes to this bug.