Summary: | Fix logic error in shouldComputeLogicalHeightFromAspectRatio | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||
Component: | CSS | Assignee: | Rob Buis <rbuis> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | changseok, clopez, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 47738 | ||||||||||
Attachments: |
|
Description
Rob Buis
2021-01-26 01:13:50 PST
Created attachment 418380 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 418463 [details]
Patch
Created attachment 418474 [details]
Patch
Comment on attachment 418474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418474&action=review > LayoutTests/TestExpectations:4452 > +webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-007.html [ ImageOnlyFailure ] No mention of this in the change log. Is this newly failing? Why? Comment on attachment 418474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418474&action=review >> LayoutTests/TestExpectations:4452 >> +webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-007.html [ ImageOnlyFailure ] > > No mention of this in the change log. Is this newly failing? Why? I am not sure yet. I expect to eventually address it with https://bugs.webkit.org/show_bug.cgi?id=220861. Committed r272049: <https://trac.webkit.org/changeset/272049> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418474 [details]. |