Bug 218042
Summary: | [WPE] Build error with ENABLE_VIDEO=OFF | ||
---|---|---|---|
Product: | WebKit | Reporter: | Bastian Krause <bst> |
Component: | Media | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Normal | CC: | aperez, fjimenez, psaavedra, smoley |
Priority: | P2 | Keywords: | DoNotImportToRadar |
Version: | WebKit Local Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=225310 |
Bastian Krause
Various errors occur when building the WPE port via:
$ cmake -DPORT=WPE -DCMAKE_BUILD_TYPE=RelWithDebInfo -GNinja -DCMAKE_BUILD_TYPE=Release -DANALYZERS=OFF -DDEBUG_FISSION=OFF -DENABLE_ACCELERATED_2D_CANVAS=OFF -DENABLE_ACCESSIBILITY=OFF -DENABLE_BUBBLEWRAP_SANDBOX=OFF -DENABLE_ENCRYPTED_MEDIA=OFF -DENABLE_GTKDOC=OFF -DENABLE_MEDIA_SOURCE=OFF -DENABLE_SHAREABLE_RESOURCE=ON -DENABLE_VIDEO=OFF -DENABLE_WEBDRIVER=ON -DENABLE_WEB_AUDIO=OFF -DENABLE_WEB_CRYPTO=ON -DENABLE_WPE_QT_API=OFF -DENABLE_XSLT=ON -DGCC_OFFLINEASM_SOURCE_MAP=OFF -DSHOULD_INSTALL_JS_SHELL=OFF -DSHOW_BINDINGS_GENERATION_PROGRESS=ON -DUSE_LD_GOLD=OFF -DUSE_OPENJPEG=OFF -DUSE_SYSTEMD=OFF -DUSE_THIN_ARCHIVES=ON -DUSE_WOFF2=OFF -DWTF_CPU_ARM64_CORTEXA53=OFF
$ ninja
Source/WebCore/editing/markup.cpp: In function ‘std::unique_ptr<WebCore::Page> WebCore::createPageForSanitizingWebContent()’:
Source/WebCore/editing/markup.cpp:181:22: error: ‘class WebCore::Settings’ has no member named ‘setMediaEnabled’; did you mean ‘setJavaEnabled’?
page->settings().setMediaEnabled(false);
^~~~~~~~~~~~~~~
setJavaEnabled
Source/WebCore/platform/graphics/GraphicsContext.cpp:1283:5: error: invalid use of incomplete type ‘class WebCore::MediaPlayer’
player.playerPrivate()->paintCurrentFrameInContext(*this, destination);
Source/WebCore/page/Page.cpp:2049:23: error: ‘class WebCore::ChromeClient’ has no member named ‘playbackControlsMediaEngineChanged’
chrome().client().playbackControlsMediaEngineChanged();
Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:1260:20: error: invalid use of incomplete type ‘class WebCore::MediaPlayer’
, m_identifier(player.identifier())
I guess most of them can be fixed with #if ENABLE(VIDEO) ... #endif.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Pablo Saavedra
I can reproduce the issue too.
Adrian Perez
Thanks for reporting!
I am doing a round of fixes for ENABLE_VIDEO=OFF in bug #232264
both for the GTK and WPE ports — let's mark this bug as duplicate.
*** This bug has been marked as a duplicate of bug 232264 ***