Bug 217434

Summary: [build.webkit.org] Ensure that builder names are valid Buildbot identifiers
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, don.olmstead, dpino, Hironori.Fujii, jbedard, pmatos, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217394
Bug Depends on:    
Bug Blocks: 175056    
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-10-07 12:28:33 PDT
We are planning to upgrade build.webkit.org to latest buildbot. In buildbot 0.9+ builder name is an identifier and can not contain space. As per http://docs.buildbot.net/0.9.8/manual/installation/nine-upgrade.html#identifiers : "An "identifier" is a nonempty unicode string of limited length, containing only ASCII alphanumeric characters along with - (dash) and _ (underscore), and not beginning with a digit." Many of the builder names already follow this naming conventions, since we have been following this convention while adding new builders. We should rename rest of the builder names as well (to not contain any space and symbols). Note that we wouldn't be able to keep the history of old builders after renaming them. However, the test results should still be available at results.webkit.org
Attachments
Patch (67.95 KB, patch)
2020-10-07 12:40 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-10-07 12:40:14 PDT
Created attachment 410767 [details] Patch
Aakash Jain
Comment 2 2020-10-07 13:01:23 PDT
<rdar://problem/35211196>
dewei_zhu
Comment 3 2020-10-07 13:04:09 PDT
r=me.
EWS
Comment 4 2020-10-07 15:09:28 PDT
Committed r268154: <https://trac.webkit.org/changeset/268154> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410767 [details].
Aakash Jain
Comment 5 2020-10-08 06:32:39 PDT
Restarted build.webkit.org to pick up this change.
Note You need to log in before you can comment on or make changes to this bug.