Bug 217394

Summary: [build.webkit.org] Ensure that steps names are valid Buildbot identifiers
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217431
https://bugs.webkit.org/show_bug.cgi?id=217434
Bug Depends on:    
Bug Blocks: 175056    
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-10-06 10:49:16 PDT
[build.webkit.org] Ensure that steps names are valid buildbot identifiers We are planning to upgrade build.webkit.org to latest buildbot. In buildbot 0.9+ step name is an identifier and can not contain space. As per http://docs.buildbot.net/0.9.8/manual/installation/nine-upgrade.html#identifiers : "An "identifier" is a nonempty unicode string of limited length, containing only ASCII alphanumeric characters along with - (dash) and _ (underscore), and not beginning with a digit." We should rename all the step names to not contain any space.
Attachments
Patch (45.12 KB, patch)
2020-10-06 11:10 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-10-06 10:49:38 PDT
<rdar://problem/35210754>
Aakash Jain
Comment 2 2020-10-06 11:10:15 PDT
Created attachment 410661 [details] Patch
EWS
Comment 3 2020-10-06 13:51:27 PDT
Committed r268071: <https://trac.webkit.org/changeset/268071> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410661 [details].
Aakash Jain
Comment 4 2020-10-08 06:32:04 PDT
Restarted build.webkit.org to pick up this change.
Note You need to log in before you can comment on or make changes to this bug.