Bug 216569

Summary: Import OscillatorNode layout tests from Blink
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216625
Bug Depends on: 216625    
Bug Blocks: 212611, 216576    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch eric.carlson: review+, ews-feeder: commit-queue-

Chris Dumez
Reported 2020-09-15 10:16:44 PDT
Import OscillatorNode layout tests from Blink.
Attachments
Patch (93.20 KB, patch)
2020-09-15 10:18 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.92 MB, patch)
2020-09-15 11:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.92 MB, patch)
2020-09-15 12:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.92 MB, patch)
2020-09-15 13:00 PDT, Chris Dumez 		eric.carlson: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-09-15 10:18:35 PDT
Created attachment 408829 [details] Patch
Geoffrey Garen
Comment 2 2020-09-15 11:33:21 PDT
EWS seems angry.
Chris Dumez
Comment 3 2020-09-15 11:49:44 PDT
Created attachment 408841 [details] Patch
Chris Dumez
Comment 4 2020-09-15 12:12:35 PDT
Created attachment 408843 [details] Patch
Chris Dumez
Comment 5 2020-09-15 13:00:36 PDT
Created attachment 408848 [details] Patch
Chris Dumez
Comment 6 2020-09-15 13:39:27 PDT
Comment on attachment 408848 [details] Patch Ready for review.
youenn fablet
Comment 7 2020-09-15 23:59:53 PDT
Comment on attachment 408848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408848&action=review > LayoutTests/ChangeLog:8 > + Import OscillatorNode layout tests from Blink. Do you know why these are not WPT tests? Can we move them to LayoutTests/imported/w3c/web-platform-tests/webaudio and upstream them? They are already testharness based so should be fine. That will make sure these tests will be kept in sync with Blink.
Chris Dumez
Comment 8 2020-09-16 08:24:32 PDT
(In reply to youenn fablet from comment #7) > Comment on attachment 408848 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408848&action=review > > > LayoutTests/ChangeLog:8 > > + Import OscillatorNode layout tests from Blink. > > Do you know why these are not WPT tests? > Can we move them to LayoutTests/imported/w3c/web-platform-tests/webaudio and > upstream them? They are already testharness based so should be fine. > That will make sure these tests will be kept in sync with Blink. These are Blink tests. I do not know why they were not upstreamed. I don't think we should be the ones to upstream them. Until they are upstreamed, the best thing I can do to gain test coverage and make sure we match Chrome behavior is to import them. This is blocking my work.
EWS
Comment 9 2020-09-16 08:34:04 PDT
Tools/Scripts/svn-apply failed to apply attachment 408848 [details] to trunk. Please resolve the conflicts and upload a new patch.
Chris Dumez
Comment 10 2020-09-16 08:34:26 PDT
<https://trac.webkit.org/changeset/267144>
Radar WebKit Bug Importer
Comment 11 2020-09-16 08:35:20 PDT
<rdar://problem/68990849>
youenn fablet
Comment 12 2020-09-16 09:09:51 PDT
I filed https://github.com/web-platform-tests/wpt/issues/25571, hopefully Chromium can do the upstream and we could then remove our own copy.
Note You need to log in before you can comment on or make changes to this bug.