Bug 215895

Summary: [webkitpy] Use webkitcorepy's auto installer for pytest packages
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, ews-watchlist, glenn, slewis, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214950
https://bugs.webkit.org/show_bug.cgi?id=217438
https://bugs.webkit.org/show_bug.cgi?id=217694
https://bugs.webkit.org/show_bug.cgi?id=217856
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2020-08-27 11:03:08 PDT
Part of removing webkitpy's autoinstaller in favor of webkitcorepy's.
Attachments
Patch (6.20 KB, patch)
2020-08-27 11:37 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (4.09 KB, patch)
2020-09-21 15:03 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (4.34 KB, patch)
2020-10-07 14:56 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-08-27 11:03:25 PDT
<rdar://problem/67885471>
Jonathan Bedard
Comment 2 2020-08-27 11:37:10 PDT
Created attachment 407420 [details] Patch
Aakash Jain
Comment 3 2020-09-21 13:23:34 PDT
Comment on attachment 407420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407420&action=review > Tools/Scripts/webkitpy/__init__.py:32 > +AutoInstall.register(Package('configparser', Version(4, 0, 2))) configparser is being added here, but not being removed? Is it a new requirement? (same with wcwidth, zipp, zope etc.) If we are adding new packages, it's better to do add in a separate patch, and keep this patch just to transition from old autoinstaller to new one.
Jonathan Bedard
Comment 4 2020-09-21 13:29:02 PDT
(In reply to Aakash Jain from comment #3) > Comment on attachment 407420 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407420&action=review > > > Tools/Scripts/webkitpy/__init__.py:32 > > +AutoInstall.register(Package('configparser', Version(4, 0, 2))) > > configparser is being added here, but not being removed? Is it a new > requirement? (same with wcwidth, zipp, zope etc.) > > If we are adding new packages, it's better to do add in a separate patch, > and keep this patch just to transition from old autoinstaller to new one. The old installer was weirdly incomplete. All the packages being added here are dependencies of packages already added. Some of this may be because we're using newer versions (namely, Python 3 compatible ones), but some of this is probably because when we added the original dependencies on pytest, we didn't audit those packages fully to add their dependencies as well.
Aakash Jain
Comment 5 2020-09-21 13:30:36 PDT
ok. rs=me
Jonathan Bedard
Comment 6 2020-09-21 15:03:51 PDT
Created attachment 409324 [details] Patch
EWS
Comment 7 2020-09-21 16:10:13 PDT
Committed r267380: <https://trac.webkit.org/changeset/267380> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409324 [details].
Truitt Savell
Comment 8 2020-09-22 09:00:57 PDT
Broke multiple test suites, reverted in https://trac.webkit.org/changeset/267410
Jonathan Bedard
Comment 9 2020-10-07 14:56:17 PDT
Created attachment 410787 [details] Patch
Jonathan Bedard
Comment 10 2020-10-07 15:23:25 PDT
This was caused by the same issue I just fixed in https://bugs.webkit.org/show_bug.cgi?id=217438, so this should be safe to land again (basically, setuptools needs the wheel package)
Aakash Jain
Comment 11 2020-10-09 10:16:53 PDT
rs=me
EWS
Comment 12 2020-10-09 10:33:21 PDT
Committed r268267: <https://trac.webkit.org/changeset/268267> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410787 [details].
Note You need to log in before you can comment on or make changes to this bug.