| Summary: | [webkitpy] Use webkitcorepy's auto installer for pytest packages | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, dewei_zhu, ews-watchlist, glenn, slewis, tsavell, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=214950 https://bugs.webkit.org/show_bug.cgi?id=217438 https://bugs.webkit.org/show_bug.cgi?id=217694 https://bugs.webkit.org/show_bug.cgi?id=217856 |
||||||||||
| Attachments: |
|
||||||||||
|
Description
Jonathan Bedard
2020-08-27 11:03:08 PDT
Created attachment 407420 [details]
Patch
Comment on attachment 407420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407420&action=review > Tools/Scripts/webkitpy/__init__.py:32 > +AutoInstall.register(Package('configparser', Version(4, 0, 2))) configparser is being added here, but not being removed? Is it a new requirement? (same with wcwidth, zipp, zope etc.) If we are adding new packages, it's better to do add in a separate patch, and keep this patch just to transition from old autoinstaller to new one. (In reply to Aakash Jain from comment #3) > Comment on attachment 407420 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407420&action=review > > > Tools/Scripts/webkitpy/__init__.py:32 > > +AutoInstall.register(Package('configparser', Version(4, 0, 2))) > > configparser is being added here, but not being removed? Is it a new > requirement? (same with wcwidth, zipp, zope etc.) > > If we are adding new packages, it's better to do add in a separate patch, > and keep this patch just to transition from old autoinstaller to new one. The old installer was weirdly incomplete. All the packages being added here are dependencies of packages already added. Some of this may be because we're using newer versions (namely, Python 3 compatible ones), but some of this is probably because when we added the original dependencies on pytest, we didn't audit those packages fully to add their dependencies as well. ok. rs=me Created attachment 409324 [details]
Patch
Committed r267380: <https://trac.webkit.org/changeset/267380> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409324 [details]. Broke multiple test suites, reverted in https://trac.webkit.org/changeset/267410 Created attachment 410787 [details]
Patch
This was caused by the same issue I just fixed in https://bugs.webkit.org/show_bug.cgi?id=217438, so this should be safe to land again (basically, setuptools needs the wheel package) rs=me Committed r268267: <https://trac.webkit.org/changeset/268267> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410787 [details]. |