Bug 214233

Summary:

REGRESSION (r261152): 10 blocks of critical sandboxing code disabled because they are guarded with HAVE(SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN)

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebKit2

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Critical

CC:

eric.carlson, ews-watchlist, fujii.hironori, glenn, jer.noble, philipj, pvollan, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=211427
https://bugs.webkit.org/show_bug.cgi?id=214244

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Darin Adler

Reported 2020-07-12 07:57:11 PDT

The change in r261152 intended to remove no-longer-needed conditionals that are now always true on Cocoa platforms. However, when I made that change I accidentally left 9 blocks of code guarded by HAVE(SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN) behind. So these were all disabled! These 9 blocks of code must either be: 1) enabled unconditionally 2) guarded by #HAVE(AUDIT_TOKEN) 3) guarded by ENABLE(SANDBOX_EXTENSIONS)

Attachments
Patch (10.86 KB, patch) 2020-07-12 08:04 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (11.44 KB, patch) 2020-07-12 08:39 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (11.44 KB, patch) 2020-07-12 08:50 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (12.11 KB, patch) 2020-07-12 09:07 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2020-07-12 08:04:12 PDT Comment hidden (obsolete)

Created attachment 404096 [details] Patch

Darin Adler

Comment 2 2020-07-12 08:04:55 PDT

Patch enables these code paths unconditionally. I’ll count on EWS to detect if I need to guard these with HAVE(AUDIO_TOKEN) or ENABLE(SANDBOX_EXTENSIONS).

Darin Adler

Comment 3 2020-07-12 08:21:45 PDT

To fix the WinCairo build I am working on a revised version that puts more code inside ENABLE(SANDBOX_EXTENSIONS).

Darin Adler

Comment 4 2020-07-12 08:39:44 PDT Comment hidden (obsolete)

Created attachment 404098 [details] Patch

Darin Adler

Comment 5 2020-07-12 08:50:01 PDT Comment hidden (obsolete)

Created attachment 404099 [details] Patch

Darin Adler

Comment 6 2020-07-12 09:07:47 PDT

Created attachment 404101 [details] Patch