Bug 210190

Summary: [ews] rename CompileWebKitToT to CompileWebKitWithoutPatch
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203959
https://bugs.webkit.org/show_bug.cgi?id=210265
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-04-08 08:50:42 PDT
Rename CompileWebKitToT to CompileWebKitWithoutPatch since that's more accurate name. In EWS, when the CompileWebKit fails, we un-apply the patch and compile same revision without patch, not the ToT. This naming would also make it consistent with other similar steps like: RunWebKitTestsWithout, RunAPITestsWithoutPatch and RunJSCTestsWithoutPatch.
Attachments
Patch (7.90 KB, patch)
2020-04-08 09:00 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-04-08 09:00:46 PDT
Created attachment 395819 [details] Patch
EWS
Comment 2 2020-04-09 03:06:05 PDT
Committed r259787: <https://trac.webkit.org/changeset/259787> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395819 [details].
Radar WebKit Bug Importer
Comment 3 2020-04-09 03:07:14 PDT
<rdar://problem/61507229>
Note You need to log in before you can comment on or make changes to this bug.