Bug 209480

Summary:	[ macOS wk1 ] webgl/2.0.0/conformance/attribs/gl-vertexattribpointer.html is flaky timing out
Product:	WebKit	Reporter:	Jacob Uphoff <jacob_uphoff>
Component:	WebGL	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	dino, jonlee, kbr, kkinnunen, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=208078
Bug Depends on:	214211
Bug Blocks:	126404, 222726

Description Jacob Uphoff 2020-03-24 09:23:49 PDT

webgl/2.0.0/conformance/attribs/gl-vertexattribpointer.html

This test has been a flaky timeout since it was unskipped in r257283 on macOS wk1 debug.

History:

https://results.webkit.org/?suite=layout-tests&test=webgl%2F2.0.0%2Fconformance%2Fattribs%2Fgl-vertexattribpointer.html

Diff:

--- /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/webgl/2.0.0/conformance/attribs/gl-vertexattribpointer-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/webgl/2.0.0/conformance/attribs/gl-vertexattribpointer-actual.txt
@@ -1,3 +1,4 @@
+FAIL: Timed out waiting for notifyDone to be called
 This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
 
 Test: ../../resources/webgl_test_files/conformance/attribs/gl-vertexattribpointer.html

Comment 1 Radar WebKit Bug Importer 2020-03-24 09:24:13 PDT

<rdar://problem/60827678>

Comment 2 Jacob Uphoff 2020-03-24 09:41:35 PDT

Set expectations here: https://trac.webkit.org/changeset/258912/webkit

Comment 3 Kenneth Russell 2020-07-31 15:12:39 PDT

James, could you please see whether this has been fixed by Bug 214211?

Comment 4 Jon Lee 2021-01-26 02:31:53 PST

This appears to remain a flaky timeout on WK1 debug.

Comment 5 Kenneth Russell 2021-01-26 15:54:13 PST

This test seems to run very quickly, so it's strange that it would time out flakily in Debug builds. James is OOO for the moment; if this is urgent can anyone else investigate it?

Comment 6 Kimmo Kinnunen 2021-03-18 00:50:17 PDT

Closing this one out. The test in general is a bit slow.
The solution is to mark the test as Slow in TestExpectations.
Later implementations could be sped up, but relative to other tests, this test probably will remain slowish.