[WebGL] Unskip runnable WebGL 2.0.0 conformance suite
Created attachment 391432 [details] Patch
<rdar://problem/59688268>
Created attachment 391571 [details] Patch
Created attachment 391572 [details] Patch
Comment on attachment 391572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391572&action=review > LayoutTests/TestExpectations:3344 > +# DEQP will likely always be skipped on regular bots due to runtime. There should be assertive clarity here. "will likely always" is hedging. When it changes, it changes. "runtime" could be misread confusingly as runtime switch rather than the literal time it takes. "DEQP is skipped on the main fleet of bots because of the long run time."
(In reply to Jon Lee from comment #5) > Comment on attachment 391572 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391572&action=review > > > LayoutTests/TestExpectations:3344 > > +# DEQP will likely always be skipped on regular bots due to runtime. > > There should be assertive clarity here. "will likely always" is hedging. > When it changes, it changes. "runtime" could be misread confusingly as > runtime switch rather than the literal time it takes. > > "DEQP is skipped on the main fleet of bots because of the long run time." Thanks! Will be addressed in the final patch; just letting this one go through tests again
Created attachment 391590 [details] Patch for landing
Comment on attachment 391590 [details] Patch for landing Clearing flags on attachment: 391590 Committed r257283: <https://trac.webkit.org/changeset/257283>
All reviewed patches have been landed. Closing bug.
It looks like these tests are all failing across the board. https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=webgl%2F2.0.0%2Fconformance%2Fbuffers%2Fbuffer-uninitialized.html&test=webgl%2F2.0.0%2Fconformance%2Fextensions%2Fangle-instanced-arrays.html&test=webgl%2F2.0.0%2Fconformance%2Frendering%2Fclipping-wide-points.html&test=webgl%2F2.0.0%2Fconformance2%2Frenderbuffers%2Fmultisampled-renderbuffer-initialization.html&test=webgl%2F2.0.0%2Fconformance2%2Frendering%2Fclipping-wide-points.html&test=webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fmisc%2Ftex-3d-size-limit.html
(In reply to Jacob Uphoff from comment #10) > It looks like these tests are all failing across the board. > > https://results.webkit.org/?suite=layout-tests&suite=layout- > tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout- > tests&test=webgl%2F2.0.0%2Fconformance%2Fbuffers%2Fbuffer-uninitialized. > html&test=webgl%2F2.0.0%2Fconformance%2Fextensions%2Fangle-instanced-arrays. > html&test=webgl%2F2.0.0%2Fconformance%2Frendering%2Fclipping-wide-points. > html&test=webgl%2F2.0.0%2Fconformance2%2Frenderbuffers%2Fmultisampled- > renderbuffer-initialization.html&test=webgl%2F2.0. > 0%2Fconformance2%2Frendering%2Fclipping-wide-points.html&test=webgl%2F2.0. > 0%2Fconformance2%2Ftextures%2Fmisc%2Ftex-3d-size-limit.html Follow-up: https://bugs.webkit.org/show_bug.cgi?id=208211
I have marked webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format.html as pass on timeout here: https://trac.webkit.org/changeset/257523/webkit
webgl/2.0.0/conformance/attribs/gl-vertexattribpointer.html This test is timing out consistently on Mac Debug wk1 History: https://results.webkit.org/?suite=layout-tests&test=webgl%2F2.0.0%2Fconformance%2Fattribs%2Fgl-vertexattribpointer.html