Bug 207422

Summary: Web Inspector: Revert slim toolbar
Product: WebKit Reporter: Jon Lee <jonlee>
Component: Web InspectorAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, mjs, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204627
https://bugs.webkit.org/show_bug.cgi?id=207317
https://bugs.webkit.org/show_bug.cgi?id=207320
https://bugs.webkit.org/show_bug.cgi?id=207318
https://bugs.webkit.org/show_bug.cgi?id=207228
https://bugs.webkit.org/show_bug.cgi?id=207322
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Jon Lee
Reported 2020-02-07 17:13:49 PST
Revert r255547
Attachments
Patch (416.44 KB, patch)
2020-02-07 17:25 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (368.71 KB, patch)
2020-02-07 18:21 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (341.47 KB, patch)
2020-02-07 18:30 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (341.91 KB, patch)
2020-02-07 19:55 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (342.54 KB, patch)
2020-02-07 20:09 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jon Lee
Comment 1 2020-02-07 17:25:53 PST
Created attachment 390151 [details] Patch
Maciej Stachowiak
Comment 2 2020-02-07 17:47:19 PST
Comment on attachment 390151 [details] Patch ChangeLog should probably have rationale.
Nikita Vasilyev
Comment 3 2020-02-07 17:49:53 PST
Retitled from "Revert r255547, r255890, r255892, r255893, and r255901".
Jon Lee
Comment 4 2020-02-07 18:05:39 PST
I'll update the Changelog.
Jon Lee
Comment 5 2020-02-07 18:21:52 PST
Created attachment 390157 [details] Patch
Jon Lee
Comment 6 2020-02-07 18:30:40 PST
Created attachment 390158 [details] Patch
Timothy Hatcher
Comment 7 2020-02-07 19:13:45 PST
Comment on attachment 390158 [details] Patch r=me with testing of your build.
Jon Lee
Comment 8 2020-02-07 19:50:29 PST
Looks like this requires one more additional patch to roll out.
Jon Lee
Comment 9 2020-02-07 19:55:26 PST
Created attachment 390162 [details] Patch
Jon Lee
Comment 10 2020-02-07 20:09:00 PST
Created attachment 390163 [details] Patch
Radar WebKit Bug Importer
Comment 12 2020-02-07 20:23:19 PST
<rdar://problem/59282501>
Note You need to log in before you can comment on or make changes to this bug.