Bug 207228 – Web Inspector: the height of the undocked title area shouldn't change when zoomed

• Status: RESOLVED
• Resolution: MOVED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page
2. detach web inspector
3. zoom in/out (⌘+ or ⌘-)
 => the height of the title area increases

[Devin Rousso]

Created attachment 389709 [details]
Patch

[Timothy Hatcher]

Comment on attachment 389709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389709&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:548
> +    }
> +    WI.settings.zoomFactor.addEventListener(WI.Setting.Event.Changed, updateZoomFactorCSSVariable);

Blank line between. Or move the function inline as a arrow function in addEventListener.

[Devin Rousso]

Created attachment 389933 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 389933 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 389933 [details]
Patch

Clearing flags on attachment: 389933

Committed r255901: <https://trac.webkit.org/changeset/255901>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59213469>

[Jon Lee]

Reopening. This was reverted by https://trac.webkit.org/changeset/256086/webkit in b207422.

[Devin Rousso]

This will be resolved by <https://webkit.org/b/207317>.