Bug 207422 - Web Inspector: Revert slim toolbar
Summary: Web Inspector: Revert slim toolbar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-07 17:13 PST by Jon Lee
Modified: 2020-02-07 20:23 PST (History)
9 users (show)

See Also:


Attachments
Patch (416.44 KB, patch)
2020-02-07 17:25 PST, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (368.71 KB, patch)
2020-02-07 18:21 PST, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (341.47 KB, patch)
2020-02-07 18:30 PST, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (341.91 KB, patch)
2020-02-07 19:55 PST, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (342.54 KB, patch)
2020-02-07 20:09 PST, Jon Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2020-02-07 17:13:49 PST
Revert r255547
Comment 1 Jon Lee 2020-02-07 17:25:53 PST
Created attachment 390151 [details]
Patch
Comment 2 Maciej Stachowiak 2020-02-07 17:47:19 PST
Comment on attachment 390151 [details]
Patch

ChangeLog should probably have rationale.
Comment 3 Nikita Vasilyev 2020-02-07 17:49:53 PST
Retitled from "Revert r255547, r255890, r255892, r255893, and r255901".
Comment 4 Jon Lee 2020-02-07 18:05:39 PST
I'll update the Changelog.
Comment 5 Jon Lee 2020-02-07 18:21:52 PST
Created attachment 390157 [details]
Patch
Comment 6 Jon Lee 2020-02-07 18:30:40 PST
Created attachment 390158 [details]
Patch
Comment 7 Timothy Hatcher 2020-02-07 19:13:45 PST
Comment on attachment 390158 [details]
Patch

r=me with testing of your build.
Comment 8 Jon Lee 2020-02-07 19:50:29 PST
Looks like this requires one more additional patch to roll out.
Comment 9 Jon Lee 2020-02-07 19:55:26 PST
Created attachment 390162 [details]
Patch
Comment 10 Jon Lee 2020-02-07 20:09:00 PST
Created attachment 390163 [details]
Patch
Comment 12 Radar WebKit Bug Importer 2020-02-07 20:23:19 PST
<rdar://problem/59282501>