Web Inspector: REGRESSION(?): Search: selecting a DOM node search result switches to the Elements Tab

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page
2. search for "div" via the Search Tab
 => as soon as results start appearing in the Search Tab, Web Inspector will instantly switch to the Elements Tab and select the node that matches the search result

[Devin Rousso]

Created attachment 389934 [details]
Patch

[BJ Burg]

Comment on attachment 389934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389934&action=review

r=me

> Source/WebInspectorUI/ChangeLog:14
> +        such, we should update it's position in the `_recentTabContentViews` list so that we can use

So, the bug is that the Search Tab results content view wasn't the most recent in the list (the most recent being preferred over, say, Elements tab) ?

[Devin Rousso]

Comment on attachment 389934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389934&action=review

>> Source/WebInspectorUI/ChangeLog:14
>> +        such, we should update it's position in the `_recentTabContentViews` list so that we can use
> 
> So, the bug is that the Search Tab results content view wasn't the most recent in the list (the most recent being preferred over, say, Elements tab) ?

Yup!

[WebKit Commit Bot]

Comment on attachment 389934 [details]
Patch

Clearing flags on attachment: 389934

Committed r255980: <https://trac.webkit.org/changeset/255980>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/59236869>

[Jon Lee]

Reopening. This was reverted by https://trac.webkit.org/changeset/256086/webkit in b207422.

[Devin Rousso]

This will be resolved by <https://webkit.org/b/207317>.