Bug 203908

Summary: REGRESSION: r252121 introduced new webgl/ failures
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: Tools / TestsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dino, eric.carlson, ews-watchlist, glenn, jer.noble, jlewis3, justin_fan, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar, LayoutTestFailure
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203763
https://bugs.webkit.org/show_bug.cgi?id=203949
Attachments:
Description Flags
WIP patch for mac side and EWS
none
Patch for landing
commit-queue: commit-queue-
Archive of layout-test-results from webkit-cq-03 for mac-highsierra
none
Please land this patch none

Truitt Savell
Reported 2019-11-06 11:24:01 PST
The changes in https://trac.webkit.org/changeset/252121/webkit Broke several tests on iOS and introduced failing tests. 11 failing tests: webgl/1.0.3/conformance/extensions/get-extension.html webgl/1.0.3/conformance/extensions/oes-texture-float.html webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit.html webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html webgl/1.0.3/conformance/more/functions/readPixelsBadArgs.html webgl/1.0.3/conformance/more/functions/texImage2DHTML.html webgl/1.0.3/conformance/more/functions/texSubImage2DHTML.html webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html webgl/1.0.3/conformance/textures/texture-npot-video.html History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fget-extension.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Foes-texture-float.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fwebgl-compressed-texture-size-limit.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fwebgl-draw-buffers.html&test=webgl%2F1.0.3%2Fconformance%2Fglsl%2Fmisc%2Fshader-with-reserved-words.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FreadPixelsBadArgs.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FtexImage2DHTML.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FtexSubImage2DHTML.html&test=webgl%2F1.0.3%2Fconformance%2Frenderbuffers%2Fframebuffer-object-attachment.html&test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Fcopy-tex-image-2d-formats.html&test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Ftexture-npot-video.html&platform=ios Results: https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20(Tests)/r252136%20(761)/results.html
Attachments
WIP patch for mac side and EWS (5.15 KB, patch)
2019-11-06 13:12 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.33 KB, patch)
2019-11-06 13:32 PST, Justin Fan 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-03 for mac-highsierra (3.36 MB, application/zip)
2019-11-06 15:30 PST, WebKit Commit Bot 		no flags
Details
Please land this patch (3.40 KB, patch)
2019-11-06 17:50 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-06 11:24:34 PST
<rdar://problem/56951561>
Justin Fan
Comment 2 2019-11-06 13:12:00 PST
Created attachment 382951 [details] WIP patch for mac side and EWS
Justin Fan
Comment 3 2019-11-06 13:32:48 PST
Created attachment 382956 [details] Patch for landing
Justin Fan
Comment 4 2019-11-06 13:34:37 PST
Just going to mark them as failing for now. Followup bug/patch later today to add new baselines.
Justin Fan
Comment 5 2019-11-06 15:04:05 PST
Seeing some extra failures. WebGL tends to be finicky based on Intel vs AMD, different GPUs, etc. ugh.
WebKit Commit Bot
Comment 6 2019-11-06 15:30:28 PST
Comment on attachment 382956 [details] Patch for landing Rejecting attachment 382956 [details] from commit-queue. New failing tests: webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html Full output: https://webkit-queues.webkit.org/results/13220282
WebKit Commit Bot
Comment 7 2019-11-06 15:30:29 PST
Created attachment 382968 [details] Archive of layout-test-results from webkit-cq-03 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-highsierra Platform: Mac OS X 10.13.6
Justin Fan
Comment 8 2019-11-06 17:50:34 PST
Created attachment 382992 [details] Please land this patch
Aakash Jain
Comment 9 2019-11-06 17:55:09 PST
Comment on attachment 382992 [details] Please land this patch Clearing flags on attachment: 382992 Committed r252164: <https://trac.webkit.org/changeset/252164>
Aakash Jain
Comment 10 2019-11-06 17:55:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.