| Summary: | [WebGL] Update WebGL 1 tests to prep for WebGL Conformance bot | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Fan <justin_fan> | ||||||||||||||
| Component: | New Bugs | Assignee: | Justin Fan <justin_fan> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, ap, dino, tsavell, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=203908 https://bugs.webkit.org/show_bug.cgi?id=203909 https://bugs.webkit.org/show_bug.cgi?id=203949 |
||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Justin Fan
2019-11-01 14:47:42 PDT
*** Bug 203766 has been marked as a duplicate of this bug. *** Created attachment 382717 [details]
WIP Patch for size concern
Created attachment 382718 [details]
WIP patch for size concern
Diff is so large patch is timing out. Yay rs=me Created attachment 382783 [details]
Patch for landing
Created attachment 382784 [details]
Patch for landing
Created attachment 382850 [details]
Patch w/ Changelog
Created attachment 382856 [details]
Patch attempt
Committed r252121: <https://trac.webkit.org/changeset/252121> The changes in https://trac.webkit.org/changeset/252121/webkit Broke several tests on iOS and introduced failing tests. 11 failing tests: webgl/1.0.3/conformance/extensions/get-extension.html webgl/1.0.3/conformance/extensions/oes-texture-float.html webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit.html webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html webgl/1.0.3/conformance/more/functions/readPixelsBadArgs.html webgl/1.0.3/conformance/more/functions/texImage2DHTML.html webgl/1.0.3/conformance/more/functions/texSubImage2DHTML.html webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html webgl/1.0.3/conformance/textures/texture-npot-video.html History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fget-extension.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Foes-texture-float.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fwebgl-compressed-texture-size-limit.html&test=webgl%2F1.0.3%2Fconformance%2Fextensions%2Fwebgl-draw-buffers.html&test=webgl%2F1.0.3%2Fconformance%2Fglsl%2Fmisc%2Fshader-with-reserved-words.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FreadPixelsBadArgs.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FtexImage2DHTML.html&test=webgl%2F1.0.3%2Fconformance%2Fmore%2Ffunctions%2FtexSubImage2DHTML.html&test=webgl%2F1.0.3%2Fconformance%2Frenderbuffers%2Fframebuffer-object-attachment.html&test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Fcopy-tex-image-2d-formats.html&test=webgl%2F1.0.3%2Fconformance%2Ftextures%2Ftexture-npot-video.html&platform=ios These two are also failing or timing out on Mac: webgl/1.0.3/conformance/textures/texture-npot-video.html webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html webgl/1.0.3/conformance/context/context-release-upon-reload.html seems flaky, in https://ews-build.webkit.org/#/builders/17/builds/5817 , it passed in layout-tests step, but failed in re-run-layout-tests step. |