Summary: | Roll ANGLE for ETC extensions and EGL_ANGLE_device_cgl | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||
Component: | ANGLE | Assignee: | Kenneth Russell <kbr> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, annulen, dino, ews-watchlist, graouts, gyuyoung.kim, Hironori.Fujii, jdarpinian, kondapallykalyan, rakuco, ryuan.choi, sergio, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=202879 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 197900, 200904, 202872 | ||||||
Attachments: |
|
Description
Kenneth Russell
2019-10-09 20:25:40 PDT
Also need this follow-up change: Conditionalize DeviceCGL implementation https://chromium.googlesource.com/angle/angle/+/c5e0ac757a112a24a0118d434e652fd7b558e6a8 Created attachment 380703 [details]
Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE This is a mega-patch, but there are no changes relative to upstream ANGLE. The only build changes needed were to remove the FrameCapture source files from the Xcode and CMake projects, and to add the new DeviceCGL.cpp/h files for the CGL backend. In the future I don't think it's worth including all the changes in the ChangeLog. Just saying ANGLE was rolled was enough. Thanks Alex for your review and help landing this patch, and Dean for the suggestion - will edit down the ChangeLog next time. <rdar://problem/56201832> Our bug importer keeps importing this without putting the keywords on. |