Bug 202163

Summary: [ews-build] Improve summary for Validate Patch step
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=195945
https://bugs.webkit.org/show_bug.cgi?id=203261
Attachments:
Description Flags
Patch
none
Change in Status bubble pop-over message
none
Patch none

Aakash Jain
Reported 2019-09-24 13:07:58 PDT
Validate Patch step can fail due to various reasons, e.g.: Bug closed, patch being obsolete/r-. However, the summary automatically generated by Buildbot for ValidatePatch for all these cases is: 'Validate Patch (failure)'. This isn't very readable/informative, and this also shows up in status-bubble hover-over messages, which looks somewhat ugly. We should improve this summary.
Attachments
Patch (1.89 KB, patch)
2019-09-24 13:13 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Change in Status bubble pop-over message (485.66 KB, image/png)
2019-09-24 13:18 PDT, Aakash Jain 		no flags
Details
Patch (2.93 KB, patch)
2019-09-24 13:39 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-09-24 13:13:11 PDT
Created attachment 379477 [details] Patch
Aakash Jain
Comment 2 2019-09-24 13:18:25 PDT
Created attachment 379479 [details] Change in Status bubble pop-over message
Alexey Proskuryakov
Comment 4 2019-09-24 13:22:14 PDT
Even better, this can stop at "Bug was already closed when EWS attempted to process it." The rest just repeats the same in a less user friendly form. The messages are only useful when there are some preliminary results, but even then, we can say something like "EWS observed failures prior to that, but couldn't determine if those were regressions yet."
Aakash Jain
Comment 5 2019-09-24 13:38:24 PDT
(In reply to Alexey Proskuryakov from comment #4) > Even better, this can stop at "Bug was already closed when EWS attempted to > process it." I thought about doing that, but didn't go ahead with that approach, since another change I would be making is to display steps from previous builds (if there are RETRIED BUILDS). > The messages are only useful when there are some preliminary results, but > even then, we can say something like "EWS observed failures prior to that, > but couldn't determine if those were regressions yet." ok, make sense. I will update the patch to stop at "Bug was already closed when EWS attempted to process it" message. I think it's still ok to improve the Buildbot summary strings, so I will keep this change as well.
Aakash Jain
Comment 6 2019-09-24 13:39:22 PDT
Created attachment 379483 [details] Patch
Aakash Jain
Comment 7 2019-09-24 13:39:51 PDT
Sample run: https://ews.webkit-uat.org/status-bubble/379139/
WebKit Commit Bot
Comment 8 2019-09-24 14:27:46 PDT
Comment on attachment 379483 [details] Patch Clearing flags on attachment: 379483 Committed r250318: <https://trac.webkit.org/changeset/250318>
WebKit Commit Bot
Comment 9 2019-09-24 14:27:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-09-24 14:28:28 PDT
<rdar://problem/55677508>
Note You need to log in before you can comment on or make changes to this bug.