Bug 202021

Summary: [FTW, WinCairo] Support running tests in Release mode
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, don.olmstead, ews-watchlist, gyuyoung.kim, Hironori.Fujii, mark.lam, pvollan, rakuco, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201597
https://bugs.webkit.org/show_bug.cgi?id=201996
Bug Depends on:    
Bug Blocks: 161817    
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2019-09-19 19:40:52 PDT
In Bug 201597, we added new features to better lock down JSC features in the potentially untrusted WebContent process. Unfortunately, this change included XPC Dictionary items used at startup to lock down JSC features before entering the main execution of the process. These changes were not done for the WinCairo or FTW ports. We need to pass the state of the JIT and whether to enable certain JSC features at process launch. Since the XPC mechanisms we use on macOS and iOS do not exist on Windows, I am implementing them as command-line flags.
Attachments
Patch (4.85 KB, patch)
2019-09-19 19:47 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2019-09-19 19:47:28 PDT
Created attachment 379196 [details] Patch
WebKit Commit Bot
Comment 2 2019-09-19 20:51:44 PDT
Comment on attachment 379196 [details] Patch Clearing flags on attachment: 379196 Committed r250119: <https://trac.webkit.org/changeset/250119>
WebKit Commit Bot
Comment 3 2019-09-19 20:51:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-09-19 20:52:19 PDT
<rdar://problem/55546547>
Note You need to log in before you can comment on or make changes to this bug.