Summary: | Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, ggaren, koivisto, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=201475 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 201546 | ||||||||
Attachments: |
|
Description
Chris Dumez
2019-09-06 10:24:19 PDT
Created attachment 378237 [details]
Patch
Comment on attachment 378237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378237&action=review > LayoutTests/storage/domstorage/localstorage/resources/private-browsing-1.html:-47 > - window.open("private-browsing-2.html", "_blank"); window.open isn't in your new test. This is what you were talking to us today about, right? (In reply to Alex Christensen from comment #2) > Comment on attachment 378237 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378237&action=review > > > LayoutTests/storage/domstorage/localstorage/resources/private-browsing-1.html:-47 > > - window.open("private-browsing-2.html", "_blank"); > > window.open isn't in your new test. This is what you were talking to us > today about, right? Yes, it is bigger due to the bug I mentioned so I wanted to split the window open case out. Comment on attachment 378237 [details]
Patch
Will beef up the API test a bit.
Created attachment 378298 [details]
Patch
Comment on attachment 378298 [details] Patch Clearing flags on attachment: 378298 Committed r249625: <https://trac.webkit.org/changeset/249625> All reviewed patches have been landed. Closing bug. |