Bug 201547

Summary:

Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, commit-queue, ggaren, koivisto, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=201475

Bug Depends on:

Bug Blocks:

201546

Attachments:

Description	Flags
Patch	none
Patch	none

Chris Dumez

Reported 2019-09-06 10:24:19 PDT

Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test so it can use a true ephemeral session instead of the testRunner.setPrivateBrowsingEnabled_DEPRECATED() hack.

Attachments
Patch (15.65 KB, patch) 2019-09-06 14:50 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (19.04 KB, patch) 2019-09-07 12:05 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-09-06 14:50:13 PDT

Created attachment 378237 [details] Patch

Alex Christensen

Comment 2 2019-09-07 09:16:03 PDT

Comment on attachment 378237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378237&action=review > LayoutTests/storage/domstorage/localstorage/resources/private-browsing-1.html:-47 > - window.open("private-browsing-2.html", "_blank"); window.open isn't in your new test. This is what you were talking to us today about, right?

Chris Dumez

Comment 3 2019-09-07 10:55:32 PDT

(In reply to Alex Christensen from comment #2) > Comment on attachment 378237 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378237&action=review > > > LayoutTests/storage/domstorage/localstorage/resources/private-browsing-1.html:-47 > > - window.open("private-browsing-2.html", "_blank"); > > window.open isn't in your new test. This is what you were talking to us > today about, right? Yes, it is bigger due to the bug I mentioned so I wanted to split the window open case out.

Chris Dumez

Comment 4 2019-09-07 12:01:06 PDT

Comment on attachment 378237 [details] Patch Will beef up the API test a bit.

Chris Dumez

Comment 5 2019-09-07 12:05:02 PDT

Created attachment 378298 [details] Patch

WebKit Commit Bot

Comment 6 2019-09-07 22:11:54 PDT

Comment on attachment 378298 [details] Patch Clearing flags on attachment: 378298 Committed r249625: <https://trac.webkit.org/changeset/249625>

WebKit Commit Bot

Comment 7 2019-09-07 22:11:56 PDT

All reviewed patches have been landed. Closing bug.