Layout Test imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html is a Flaky Failure

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Russell Epstein]

The following layout test is a flaky failure on all platforms:

imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html

This test is failing in a very similar way to the issue stated (and "resolved") in bug 169621. The test is outputting the proper content, but the content is not always in the correct order (test not properly waiting/race?).

Steps to Reproduce:

run-webkit-tests --iter 100 -f imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html

Test History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=imported%2Fw3c%2Fweb-platform-tests%2FIndexedDB%2Ffire-error-event-exception.html%20

Diff:

--- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception-actual.txt
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: line 32: Error
 CONSOLE MESSAGE: line 42: Error
 CONSOLE MESSAGE: line 51: Error
 CONSOLE MESSAGE: line 63: Error
@@ -8,6 +7,7 @@
 CONSOLE MESSAGE: line 110: Error
 CONSOLE MESSAGE: line 122: Error
 CONSOLE MESSAGE: line 132: Error
+CONSOLE MESSAGE: line 32: Error
 CONSOLE MESSAGE: line 150: Error
 CONSOLE MESSAGE: line 160: Error
 CONSOLE MESSAGE: line 169: Error

[Radar WebKit Bug Importer]

<rdar://problem/55046055>

[Sihui Liu]

Created attachment 378254 [details]
Patch

[EWS Watchlist]

Comment on attachment 378254 [details]
Patch

Attachment 378254 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13007997

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 378261 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Sihui Liu]

Created attachment 378385 [details]
Patch

[Ryan Haddad]

Will this fix take care of https://bugs.webkit.org/show_bug.cgi?id=169760, too?

[Sihui Liu]

(In reply to Ryan Haddad from comment #6)
> Will this fix take care of https://bugs.webkit.org/show_bug.cgi?id=169760,
> too?

I think so. It looks like these two are the same cause. I am not seeing the error of 169760 with this patch.

[Ryan Haddad]

EWS seems happy. Who should review this?

[Chris Dumez]

Comment on attachment 378385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378385&action=review

> Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:513
> +    WTFLogAlways("sihuil: [%p]IDBTransaction::commit()", this);

This should probably not be there.

[Sihui Liu]

Created attachment 378663 [details]
Patch

[Sihui Liu]

ping for review..

[WebKit Commit Bot]

Comment on attachment 378663 [details]
Patch

Clearing flags on attachment: 378663

Committed r250732: <https://trac.webkit.org/changeset/250732>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This test remains flaky - maybe even more then before, because the commit queue hit it twice recently

 PASS Exception in error event handler on request 
 PASS Exception in error event handler on request, with preventDefault 
 PASS Exception in error event listener on request 
 PASS Exception in error event listener ("handleEvent" lookup) on request 
 FAIL Exception in error event listener (non-callable "handleEvent") on request assert_equals: expected "AbortError" but got "ConstraintError"
-PASS Exception in second error event listener on request 
+TIMEOUT Exception in second error event listener on request Test timed out
 PASS Exception in first error event listener on request, transaction active in second 
-PASS Exception in error event handler on transaction 
-PASS Exception in error event handler on transaction, with preventDefault 
-PASS Exception in error event listener on transaction 
-PASS Exception in second error event listener on transaction 
+TIMEOUT Exception in error event handler on transaction Test timed out
+TIMEOUT Exception in error event handler on transaction, with preventDefault Test timed out
+TIMEOUT Exception in error event listener on transaction Test timed out
+TIMEOUT Exception in second error event listener on transaction Test timed out
 PASS Exception in first error event listener on transaction, transaction active in second 
-PASS Exception in error event handler on connection 
-PASS Exception in error event handler on connection, with preventDefault 
-PASS Exception in error event listener on connection 
-PASS Exception in second error event listener on connection 
+TIMEOUT Exception in error event handler on connection Test timed out
+TIMEOUT Exception in error event handler on connection, with preventDefault Test timed out
+TIMEOUT Exception in error event listener on connection Test timed out
+TIMEOUT Exception in second error event listener on connection Test timed out
 PASS Exception in first error event listener on connection, transaction active in second

[Alexey Proskuryakov]

*** Bug 202799 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

The commit-queue just saw imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html flake (text diff) while processing attachment 385018 [details] on bug 204949.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 385024 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html flake (text diff) while processing attachment 386673 [details] on bug 205326.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 386683 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html flake (text diff) while processing attachment 386899 [details] on bug 205833.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 387029 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html flake (text diff) while processing attachment 387522 [details] on bug 206160.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 387544 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html flake (text diff) while processing attachment 388151 [details] on bug 206473.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 388155 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html flake (text diff) while processing attachment 388326 [details] on bug 206460.
Bot: webkit-cq-02  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 388334 [details]
Archive of layout-test-results from webkit-cq-02

[WebKit Commit Bot]

The commit-queue just saw imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html flake (text diff) while processing attachment 388495 [details] on bug 206449.
Bot: webkit-cq-02  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 388507 [details]
Archive of layout-test-results from webkit-cq-02

[WebKit Commit Bot]

The commit-queue just saw imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html flake (text diff) while processing attachment 389123 [details] on bug 206899.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 389163 [details]
Archive of layout-test-results from webkit-cq-03

[Matt Lewis]

*** Bug 169760 has been marked as a duplicate of this bug. ***

[Matt Lewis]

Marked as flaky for Jacob in https://trac.webkit.org/changeset/255502/webkit

[Sihui Liu]

Created attachment 434539 [details]
Patch

[Sihui Liu]

Created attachment 434604 [details]
Patch

[youenn fablet]

Comment on attachment 434604 [details]
Patch

I do not think there is a need for review given there is no change of source code.

[Sihui Liu]

(In reply to youenn fablet from comment #36)
> Comment on attachment 434604 [details]
> Patch
> 
> I do not think there is a need for review given there is no change of source
> code.

oh I see :)

[EWS]

Committed r280480 (240115@main): <https://commits.webkit.org/240115@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434604 [details].