Bug 205833 – Add a move constructor to IDBResultData

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sihui Liu]

<rdar://problem/58146233>

[Sihui Liu]

Created attachment 386887 [details]
Patch

[youenn fablet]

Comment on attachment 386887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386887&action=review

> Source/WebCore/Modules/indexeddb/shared/IDBResultData.h:91
> +    WEBCORE_EXPORT IDBResultData(IDBResultData&&);

Can we just do IDBResultData(IDBResultData&&) = default given we do this for operator=(&&)?
Or simply remove IDBResultData(const IDBResultData&)?

[Sihui Liu]

Created attachment 386899 [details]
Patch

[Sihui Liu]

(In reply to youenn fablet from comment #2)
> Comment on attachment 386887 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386887&action=review
> 
> > Source/WebCore/Modules/indexeddb/shared/IDBResultData.h:91
> > +    WEBCORE_EXPORT IDBResultData(IDBResultData&&);
> 
> Can we just do IDBResultData(IDBResultData&&) = default given we do this for
> operator=(&&)?

Yes.

> Or simply remove IDBResultData(const IDBResultData&)?

Compile error.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 386899 [details]:

imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html bug 201481 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 386899 [details]
Patch

Clearing flags on attachment: 386899

Committed r254155: <https://trac.webkit.org/changeset/254155>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Sihui Liu]

*** Bug 205816 has been marked as a duplicate of this bug. ***