Bug 206160 - Import the update of img-aspect-ratio.html
Summary: Import the update of img-aspect-ratio.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: cathiechen
URL:
Keywords: InRadar
Depends on:
Blocks: 201641
  Show dependency tree / graph
 
Reported: 2020-01-12 20:42 PST by cathiechen
Modified: 2020-01-13 15:36 PST (History)
9 users (show)

See Also:

Attachments
Patch (10.89 KB, patch)
2020-01-12 20:46 PST, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (11.08 KB, patch)
2020-01-13 05:45 PST, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (11.08 KB, patch)
2020-01-13 06:35 PST, cathiechen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description cathiechen 2020-01-12 20:42:15 PST 
parseInt() of img-aspect-ratio.html has been changed to parseFloat() on WPT, we need to import this update.
Comment 1 cathiechen 2020-01-12 20:46:34 PST 
Created attachment 387501 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2020-01-13 05:17:40 PST 
Comment on attachment 387501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387501&action=review

> LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/align.html:3
> +<script src="/resources/testharness.js"></script>

Can you please check what's our convention and explain in the changelog why this change happens?
Comment 3 cathiechen 2020-01-13 05:45:59 PST 
Created attachment 387517 [details]
Patch
Comment 4 cathiechen 2020-01-13 06:35:09 PST 
Created attachment 387522 [details]
Patch
Comment 5 WebKit Commit Bot 2020-01-13 10:27:55 PST 
The commit-queue encountered the following flaky tests while processing attachment 387522 [details]:

The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-01-13 10:28:28 PST 
The commit-queue encountered the following flaky tests while processing attachment 387522 [details]:

inspector/debugger/breakpoint-scope.html bug 205646 (authors: drousso@apple.com and joepeck@webkit.org)
imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html bug 201481 (authors: shvaikalesh@gmail.com and youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-01-13 15:34:59 PST 
The commit-queue encountered the following flaky tests while processing attachment 387522 [details]:

media/modern-media-controls/compact-media-controls/compact-media-controls-constructor.html bug 193587 (author: graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-01-13 15:35:29 PST 
Comment on attachment 387522 [details]
Patch

Clearing flags on attachment: 387522

Committed r254461: <https://trac.webkit.org/changeset/254461>
Comment 9 WebKit Commit Bot 2020-01-13 15:35:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-01-13 15:36:12 PST 
<rdar://problem/58547152>