Bug 201450

Summary: [Win] Support Per-Monitor (V2) DPI Awareness
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKit Misc.Assignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, don.olmstead, ews-watchlist, pvollan, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=146335
Attachments:
Description Flags
WIP patch
none
WIP patch
none
Patch
none
Archive of layout-test-results from ews212 for win-future none

Fujii Hironori
Reported 2019-09-03 23:35:53 PDT
[Win] Support Per-Monitor (V2) DPI Awareness https://docs.microsoft.com/en-us/windows/win32/hidpi/high-dpi-desktop-application-development-on-windows
Attachments
WIP patch (2.38 KB, patch)
2019-09-03 23:36 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
WIP patch (2.65 KB, patch)
2019-09-04 03:05 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (4.29 KB, patch)
2019-09-04 19:38 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews212 for win-future (13.88 MB, application/zip)
2019-09-04 21:25 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-09-03 23:36:07 PDT
Created attachment 377961 [details] WIP patch
Fujii Hironori
Comment 2 2019-09-04 03:05:21 PDT
Created attachment 377968 [details] WIP patch
Brent Fulgham
Comment 3 2019-09-04 09:21:20 PDT
Comment on attachment 377968 [details] WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=377968&action=review > Tools/MiniBrowser/win/WinMain.cpp:73 > + ::SetProcessDPIAware(); It seems like we would need this change in the WebProcess, too.
Fujii Hironori
Comment 4 2019-09-04 18:56:06 PDT
Comment on attachment 377968 [details] WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=377968&action=review >> Tools/MiniBrowser/win/WinMain.cpp:73 >> + ::SetProcessDPIAware(); > > It seems like we would need this change in the WebProcess, too. Web process doesn't use HWND at all at the moment (at least in WinCairo). I will do it in Bug 201361 or Bug 186364.
Fujii Hironori
Comment 5 2019-09-04 19:33:11 PDT
I need to replace following APIs, but it's not simple task because Web process doesn't know WebView's HWND at the moment. GetSystemMetrics → GetSystemMetricsForDpi SystemParametersInfo → SystemParametersInfoForDpi I'll do that task in the follow-up patch.
Fujii Hironori
Comment 6 2019-09-04 19:38:49 PDT
Created attachment 378040 [details] Patch
EWS Watchlist
Comment 7 2019-09-04 21:25:28 PDT
Comment on attachment 378040 [details] Patch Attachment 378040 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12998620 New failing tests: fast/block/float/float-with-anonymous-previous-sibling.html
EWS Watchlist
Comment 8 2019-09-04 21:25:30 PDT
Created attachment 378042 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Fujii Hironori
Comment 9 2019-09-04 21:59:30 PDT
(In reply to Build Bot from comment #7) > New failing tests: > fast/block/float/float-with-anonymous-previous-sibling.html This test is flaky on AppleWin. Bug 194305 Comment 3 Bug 196717 Comment 8 Bug 198680 Comment 21
Fujii Hironori
Comment 10 2019-09-04 22:27:41 PDT
Filed: Bug 201491 – [AppleWin] fast/block/float/float-with-anonymous-previous-sibling.html is failing as flaky ImageOnlyFailure
Fujii Hironori
Comment 11 2019-09-05 18:50:16 PDT
Comment on attachment 378040 [details] Patch Clearing flags on attachment: 378040 Committed r249559: <https://trac.webkit.org/changeset/249559>
Fujii Hironori
Comment 12 2019-09-05 18:50:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2019-09-05 18:51:27 PDT
<rdar://problem/55095795>
Note You need to log in before you can comment on or make changes to this bug.