Summary: | [ews-app] Status bubble should only display important messages in pop-over | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aakash_jain, ap, jbedard, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=196550 https://bugs.webkit.org/show_bug.cgi?id=196584 https://bugs.webkit.org/show_bug.cgi?id=201557 https://bugs.webkit.org/show_bug.cgi?id=208865 https://bugs.webkit.org/show_bug.cgi?id=225076 |
||||||||||
Attachments: |
|
Description
Aakash Jain
2019-08-29 13:13:36 PDT
Created attachment 377614 [details]
Patch
Created attachment 377615 [details]
Change in builder steps display
Created attachment 377616 [details]
Change in tester steps display
Comment on attachment 377614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377614&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:56 > + STEPS_TO_HIDE = ['^Archived built product$', '^Uploaded built product$', '^Transferred archive to S3$', My only question is: should this be inverted? As in 'STEPS_TO_SHOW'? > My only question is: should this be inverted? As in 'STEPS_TO_SHOW'?
Maintaining whitelist would be more difficult in long run, as we add more and more steps.
Consequences for missing something from blacklist is small (extra step being displayed). But consequence of missing something from whitelist will be larger (important step not visible).
Committed r249294: <https://trac.webkit.org/changeset/249294> |