| Summary: | [ews-build] Enable WPE and GTK queues on new EWS | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, aperez, ap, commit-queue, ews-watchlist, jbedard, mcatanzaro, psaavedra, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=196641 https://bugs.webkit.org/show_bug.cgi?id=199238 https://bugs.webkit.org/show_bug.cgi?id=199408 https://bugs.webkit.org/show_bug.cgi?id=199422 https://bugs.webkit.org/show_bug.cgi?id=196657 |
||||||||||
| Attachments: |
|
||||||||||
|
Description
Aakash Jain
2019-06-26 13:52:10 PDT
Created attachment 372949 [details]
Patch
Created attachment 373387 [details]
Patch
Attachment 373387 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:587: [TestCompileWebKit.test_success_gtk] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:587: [TestCompileWebKit.test_success_gtk] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:602: [TestCompileWebKit.test_success_wpe] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:602: [TestCompileWebKit.test_success_wpe] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
Total errors found: 4 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Sample runs: https://ews-build.webkit-uat.org/#/builders/7/builds/477 https://ews-build.webkit-uat.org/#/builders/7/builds/438 Created attachment 373403 [details]
Patch for landing
Updated BuildSlaveSupport/ews-app/ews/views/statusbubble.py to enable wpe and gtk status bubbles.
Comment on attachment 373403 [details] Patch for landing Clearing flags on attachment: 373403 Committed r247131: <https://trac.webkit.org/changeset/247131> All reviewed patches have been landed. Closing bug. |