AFAICT, there's no good reason why we don't generate the `computedProperties` list in CSSComputedStyleDeclaration.cpp from CSSProperties.json (or some other source). I think we should migrate to a blacklist (take the full list of `CSSPropertyID` and remove those that aren't a longhand property) instead of a whitelist (what we have now, where it's a hardcoded list of items to include).
Comment on attachment 371675[details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=371675&action=review> Source/WebCore/css/makeprop.pl:493
> + my @longhands = @{$propertiesWithStyleBuilderOptions{$name}{"longhands"}};
Should we not skip properties that only have one longhand property? This way, properties like `page-break-after` would also be shown with `break-after`.
Comment on attachment 371677[details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=371677&action=review> Source/WebCore/css/makeprop.pl:493
> + if (scalar @longhands != 1) {
Adding this causes the following to also be shown:
- CSSPropertyAll
- CSSPropertyPageBreakAfter
- CSSPropertyPageBreakBefore
- CSSPropertyPageBreakInside
- CSSPropertyWebkitColumnBreakAfter
- CSSPropertyWebkitColumnBreakBefore
- CSSPropertyWebkitColumnBreakInside
Created attachment 371679[details]
Archive of layout-test-results from ews102 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 371680[details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 371684[details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Created attachment 371685[details]
Archive of layout-test-results from ews113 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 371698[details]
Archive of layout-test-results from ews211 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 371699[details]
Archive of layout-test-results from ews215 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 371775[details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=371775&action=review
Seems fine.
> Source/WebCore/ChangeLog:9
> + A property should be listed as part of a `CSSStyleâDeclarationâ` if:
Weird characters?
> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:-96
> -// List of all properties we know how to compute, omitting shorthands.
> -static const CSSPropertyID computedProperties[] = {
What is the diff between the old list and the new list? I assume touch-action, but did we add any others?
> Source/WebCore/css/makeprop.pl:487
> +print HEADER "static const CSSPropertyID computedPropertyIDs[] = {\n";
> +my $numComputedPropertyIDs = 0;
> +foreach my $name (@names) {
Should we sort this list? I think that would be convenient, it was semi-sorted before.
> Source/WebCore/css/makeprop.pl:491
> + # Skip Shorthand properties if they have a non-internal longhand property.
Drop "Shorthand" and just say `Skip properties if they have a non-internal longhand property.`?
> Source/WebCore/css/makeprop.pl:509
> + $numComputedPropertyIDs = $numComputedPropertyIDs + 1;
You can use ++ or just += in perl.
$numComputedPropertyIDs += 1;
> LayoutTests/ChangeLog:9
> + * imported/w3c/web-platform-tests/infrastructure/assumptions/html-elements-expected.txt:
Ew, I wonder what this test is doing...
Created attachment 371787[details]
Archive of layout-test-results from ews100 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 371788[details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 371791[details]
Archive of layout-test-results from ews112 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 371794[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Created attachment 371795[details]
Archive of layout-test-results from ews212 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 371803[details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 371807[details]
Archive of layout-test-results from ews100 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 371808[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Created attachment 371810[details]
Archive of layout-test-results from ews115 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 371815[details]
Archive of layout-test-results from ews212 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 371904[details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 371907[details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 371910[details]
Archive of layout-test-results from ews113 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 371911[details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Created attachment 371913[details]
Archive of layout-test-results from ews214 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 371926[details]
Archive of layout-test-results from ews100 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 371927[details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 371928[details]
Archive of layout-test-results from ews114 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 371931[details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
2019-06-08 14:55 PDT, Devin Rousso
2019-06-08 14:56 PDT, Devin Rousso
2019-06-08 14:56 PDT, Devin Rousso
2019-06-08 14:56 PDT, Devin Rousso
2019-06-08 14:57 PDT, Devin Rousso
2019-06-08 15:09 PDT, Devin Rousso
2019-06-08 15:14 PDT, Devin Rousso
2019-06-08 15:25 PDT, Devin Rousso
2019-06-08 16:24 PDT, EWS Watchlist
2019-06-08 16:33 PDT, EWS Watchlist
2019-06-08 17:19 PDT, EWS Watchlist
2019-06-08 17:20 PDT, EWS Watchlist
2019-06-08 19:55 PDT, EWS Watchlist
2019-06-08 19:58 PDT, EWS Watchlist
2019-06-10 14:30 PDT, Devin Rousso
2019-06-10 15:47 PDT, EWS Watchlist
2019-06-10 15:55 PDT, EWS Watchlist
2019-06-10 16:25 PDT, EWS Watchlist
2019-06-10 16:37 PDT, EWS Watchlist
2019-06-10 16:44 PDT, EWS Watchlist
2019-06-10 17:13 PDT, Devin Rousso
2019-06-10 17:17 PDT, Devin Rousso
2019-06-10 18:24 PDT, EWS Watchlist
2019-06-10 19:09 PDT, EWS Watchlist
2019-06-10 19:23 PDT, EWS Watchlist
2019-06-10 19:36 PDT, EWS Watchlist
2019-06-10 20:19 PDT, EWS Watchlist
2019-06-11 17:21 PDT, Devin Rousso
2019-06-11 17:40 PDT, Devin Rousso
2019-06-11 18:37 PDT, EWS Watchlist
2019-06-11 18:44 PDT, EWS Watchlist
2019-06-11 19:15 PDT, EWS Watchlist
2019-06-11 19:16 PDT, EWS Watchlist
2019-06-11 19:31 PDT, EWS Watchlist
2019-06-11 20:35 PDT, Devin Rousso
2019-06-11 21:53 PDT, EWS Watchlist
2019-06-11 22:00 PDT, EWS Watchlist
2019-06-11 22:29 PDT, EWS Watchlist
2019-06-11 22:42 PDT, EWS Watchlist
2019-06-12 11:20 PDT, Devin Rousso
2019-06-12 11:41 PDT, Devin Rousso
2019-06-13 20:34 PDT, Devin Rousso
2019-10-24 13:02 PDT, Devin Rousso