Bug 198610

Summary: Restrict fast clicks everywhere to desktop content mode
Product: WebKit Reporter: Antoine Quint <graouts>
Component: UI EventsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, sroberts, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 198636    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2019-06-06 07:20:12 PDT
Restrict fast clicks everywhere to desktop content mode
Attachments
Patch (7.85 KB, patch)
2019-06-06 07:21 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2019-06-06 07:21:09 PDT
Created attachment 371494 [details] Patch
Antoine Quint
Comment 2 2019-06-06 07:21:15 PDT
<rdar://problem/50114230>
Antoine Quint
Comment 3 2019-06-06 07:22:45 PDT
I wasn't sure if: 1. this should control the fasterClicks or fastClicksEverywhere preference 2. tracking the desktop mode state on WebPageProxy was the right thing to do
WebKit Commit Bot
Comment 4 2019-06-06 12:32:58 PDT
Comment on attachment 371494 [details] Patch Clearing flags on attachment: 371494 Committed r246165: <https://trac.webkit.org/changeset/246165>
WebKit Commit Bot
Comment 5 2019-06-06 12:32:59 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 6 2019-06-06 17:28:14 PDT
Re-opened since this is blocked by bug 198636
Antoine Quint
Comment 7 2019-06-07 13:28:24 PDT
*** Bug 196236 has been marked as a duplicate of this bug. ***
Antoine Quint
Comment 8 2019-06-07 13:55:53 PDT
Committed r246213: <https://trac.webkit.org/changeset/246213>
Note You need to log in before you can comment on or make changes to this bug.