Bug 198589

Summary: Add --[no]-xcbuild to build-* scripts
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: aakash_jain, ap, dbates, ews-watchlist, gsnedders, keith_miller
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=198613
https://bugs.webkit.org/show_bug.cgi?id=198586
Attachments:
Description Flags
Patch ap: review-

Jonathan Bedard
Reported 2019-06-05 17:04:21 PDT
To support ASan builds, we need --[no]-xcbuild flags supported in many of our build-* scripts.
Attachments
Patch (8.22 KB, patch)
2019-06-05 17:20 PDT, Jonathan Bedard 		ap: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-06-05 17:20:33 PDT
Created attachment 371456 [details] Patch
Alexey Proskuryakov
Comment 2 2019-06-06 10:01:26 PDT
Comment on attachment 371456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371456&action=review > Tools/ChangeLog:8 > + The --no-xcbuild flag is needed for ASan builds, and right now, only There is a better way to fix ASan, discussed in person. I don't think that we want to add more manual switches for the build system. Since the old build system is deprecated, scripts should just automatically use XCBuild wherever possible, and there needn't be a way to manually override, except for the person who is working on XCBuild support (and they can do it with a local patch). There is indeed an undesirable behavior where run-webkit-tests ends up rebuilding tools with XCBuild even though make didn't. This doesn't seem like a pressing problem though, and it will resolve itself once everything is XCBuild.
Sam Sneddon [:gsnedders]
Comment 3 2021-05-05 05:40:26 PDT
*** This bug has been marked as a duplicate of bug 197668 ***
Note You need to log in before you can comment on or make changes to this bug.