Bug 198613 - Remove obsolete TOOLCHAINS overrides from asan.xcconfig
Summary: Remove obsolete TOOLCHAINS overrides from asan.xcconfig
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-06 10:09 PDT by Jonathan Bedard
Modified: 2019-06-06 11:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2019-06-06 10:20 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.23 KB, patch)
2019-06-06 11:12 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-06-06 10:09:42 PDT 
We already removed the changes in https://trac.webkit.org/changeset/177746/webkit for every thing except for ASan.
Comment 1 Jonathan Bedard 2019-06-06 10:20:00 PDT 
Created attachment 371507 [details]
Patch
Comment 2 Jonathan Bedard 2019-06-06 10:20:52 PDT 
Probably more accurate to say we're removing <https://trac.webkit.org/changeset/177703/webkit>.
Comment 3 Alexey Proskuryakov 2019-06-06 10:38:27 PDT 
Comment on attachment 371507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371507&action=review

> Tools/ChangeLog:3
> +        Use default toolchain in ASan xcconfig

I would call this "remove obsolete TOOLCHAINS overrides from asan.xcconfig". Unfortunately, "default" has two distinct meanings in this context - one is "default", and another what Xcode defaults to. As you can see, older OSes required changing the default to "default".
Comment 4 Jonathan Bedard 2019-06-06 11:12:20 PDT 
Created attachment 371511 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-06-06 11:54:50 PDT 
Comment on attachment 371511 [details]
Patch for landing

Clearing flags on attachment: 371511

Committed r246161: <https://trac.webkit.org/changeset/246161>
Comment 6 WebKit Commit Bot 2019-06-06 11:54:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-06-06 11:55:16 PDT 
<rdar://problem/51493464>