Bug 198586 - webkitpy: Support ASan as a style
Summary: webkitpy: Support ASan as a style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-05 15:52 PDT by Jonathan Bedard
Modified: 2019-06-06 11:44 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.60 KB, patch)
2019-06-05 17:11 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (4.61 KB, patch)
2019-06-06 11:01 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-06-05 15:52:41 PDT 
Our configuration scripts support ASan, run-webkit-tests just isn't smart enough to consume it.
Comment 1 Radar WebKit Bug Importer 2019-06-05 15:53:19 PDT 
<rdar://problem/51459088>
Comment 2 Jonathan Bedard 2019-06-05 17:08:27 PDT 
This will need <https://bugs.webkit.org/show_bug.cgi?id=198589> to land first.
Comment 3 Jonathan Bedard 2019-06-05 17:11:44 PDT 
Created attachment 371454 [details]
Patch
Comment 4 Jonathan Bedard 2019-06-06 10:22:54 PDT 
We can't actually do the buildbot changes for this to be used until we fix the Asan build (originally <https://bugs.webkit.org/show_bug.cgi?id=198589>, but now we're going to do <https://bugs.webkit.org/show_bug.cgi?id=198613>). But, this change is safe to land, it has no effect on building.
Comment 5 WebKit Commit Bot 2019-06-06 10:24:02 PDT 
Comment on attachment 371454 [details]
Patch

Rejecting attachment 371454 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 371454, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/12396876
Comment 6 Jonathan Bedard 2019-06-06 11:01:59 PDT 
Created attachment 371509 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-06-06 11:44:10 PDT 
Comment on attachment 371509 [details]
Patch for landing

Clearing flags on attachment: 371509

Committed r246159: <https://trac.webkit.org/changeset/246159>
Comment 8 WebKit Commit Bot 2019-06-06 11:44:11 PDT 
All reviewed patches have been landed.  Closing bug.