Bug 197668 - Add option to build-webkit to control whether or not XCBuild is used
Summary: Add option to build-webkit to control whether or not XCBuild is used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-07 11:59 PDT by Keith Rollin
Modified: 2019-05-07 14:38 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.19 KB, patch)
2019-05-07 12:08 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff
Do the undef thing. (5.17 KB, patch)
2019-05-07 13:00 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-05-07 11:59:19 PDT
Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not. Also update build-webkit and the makefiles with the foundation for automatically using XCBuild when the conditions allow it. This latter facility is currently turned off until Xcode fully supports building WebKit with XCBuild.
Comment 1 Radar WebKit Bug Importer 2019-05-07 11:59:30 PDT
<rdar://problem/50549728>
Comment 2 Keith Rollin 2019-05-07 12:08:58 PDT
Created attachment 369309 [details]
Patch
Comment 3 Tim Horton 2019-05-07 12:16:52 PDT
Comment on attachment 369309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369309&action=review

> Tools/Scripts/build-webkit:76
> +my $xcbuild = -1;

undef is also an option

> Makefile.shared:48
> +	CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()')

😲
Comment 4 Keith Rollin 2019-05-07 12:36:22 PDT
(In reply to Tim Horton from comment #3)
> Comment on attachment 369309 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369309&action=review
> 
> > Tools/Scripts/build-webkit:76
> > +my $xcbuild = -1;
> 
> undef is also an option

Thanks. My perl is a bit rusty and I'd forgotten this. I actually did a web search for the idiomatic approach to tri-state variables, but didn't turn that one up.

> 
> > Makefile.shared:48
> > +	CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()')
> 
> 😲

I don't understand what you mean by that.
Comment 5 Tim Horton 2019-05-07 12:59:10 PDT
(In reply to Keith Rollin from comment #4)
> (In reply to Tim Horton from comment #3)
> > Comment on attachment 369309 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=369309&action=review
> > 
> > > Tools/Scripts/build-webkit:76
> > > +my $xcbuild = -1;
> > 
> > undef is also an option
> 
> Thanks. My perl is a bit rusty and I'd forgotten this. I actually did a web
> search for the idiomatic approach to tri-state variables, but didn't turn
> that one up.

OK!

> > 
> > > Makefile.shared:48
> > > +	CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()')
> > 
> > 😲
> 
> I don't understand what you mean by that.

Nothing actionable, just pretend that's what my face looked like while reading.
Comment 6 Alex Christensen 2019-05-07 13:00:05 PDT
Comment on attachment 369309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369309&action=review

>>> Makefile.shared:48
>>> +	CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()')
>> 
>> 😲
> 
> I don't understand what you mean by that.

This is the most duct tape line of code I've ever seen.
Comment 7 Keith Rollin 2019-05-07 13:00:09 PDT
Created attachment 369318 [details]
Do the undef thing.
Comment 8 Keith Rollin 2019-05-07 13:01:08 PDT
(In reply to Alex Christensen from comment #6)
> Comment on attachment 369309 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369309&action=review
> 
> >>> Makefile.shared:48
> >>> +	CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print canUseXCBuild()')
> >> 
> >> 😲
> > 
> > I don't understand what you mean by that.
> 
> This is the most duct tape line of code I've ever seen.

What would you prefer?
Comment 9 Alex Christensen 2019-05-07 13:14:40 PDT
CMake
Comment 10 WebKit Commit Bot 2019-05-07 14:38:33 PDT
Comment on attachment 369318 [details]
Do the undef thing.

Clearing flags on attachment: 369318

Committed r245037: <https://trac.webkit.org/changeset/245037>
Comment 11 WebKit Commit Bot 2019-05-07 14:38:35 PDT
All reviewed patches have been landed.  Closing bug.