Bug 198073

Summary: SVGPropertyTraits and SVG enum types clean up
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: NEW ---    
Severity: Normal CC: ews-watchlist, zimmermann
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 192519, 197831, 198122    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
ews-watchlist: commit-queue-
Patch for review
sabouhallawa: review?
Archive of layout-test-results from ews211 for win-future none

Description Said Abou-Hallawa 2019-05-21 08:35:42 PDT 
Delete unnecessary and repeated code for parsing SVG enum types and primitive types.
Comment 1 Said Abou-Hallawa 2019-05-21 09:33:46 PDT 
Created attachment 370324 [details]
Patch
Comment 2 EWS Watchlist 2019-05-21 09:35:28 PDT 
Attachment 370324 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:34:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:35:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 72 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Said Abou-Hallawa 2019-05-21 18:40:58 PDT 
Created attachment 370367 [details]
Patch
Comment 4 EWS Watchlist 2019-05-21 18:43:55 PDT 
Attachment 370367 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:34:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:35:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:36:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 72 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Said Abou-Hallawa 2019-05-21 18:45:11 PDT 
Created attachment 370368 [details]
Patch for review
Comment 6 EWS Watchlist 2019-05-22 07:52:34 PDT 
Comment on attachment 370367 [details]
Patch

Attachment 370367 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12256590

New failing tests:
storage/indexeddb/modern/get-keyrange.html
js/dom/try-catch-crash.html
js/dom/custom-constructors.html
Comment 7 EWS Watchlist 2019-05-22 07:52:40 PDT 
Created attachment 370395 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit