Bug 197850

Summary: New EWS: api-ios bubble and info does not differentiate between patch compile failure and ToT compile failure
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199025
Attachments:
Description Flags
Misleading compile time failure reason
none
EWS page showing ToT compile failure none

Daniel Bates
Reported 2019-05-13 13:22:35 PDT
Created attachment 369772 [details] Misleading compile time failure reason New EWS api-ios bubble and the HTML title text (shown when you hover over the bubble) does not differentiate between patch compile failure and ToT compile failure. This caused me to have to take the time to investigate the "failure" for my patch attachment #369760 [details] (bug #197848) only to discover that the EWS bot cannot even build ToT. The old EWS differentiated this case and the HTML title text would reflect the fact that ToT could not be built.
Attachments
Misleading compile time failure reason (440.56 KB, image/png)
2019-05-13 13:22 PDT, Daniel Bates 		no flags
Details
EWS page showing ToT compile failure (465.71 KB, image/png)
2019-05-13 13:22 PDT, Daniel Bates 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-05-13 13:22:47 PDT
<rdar://problem/50735783>
Daniel Bates
Comment 2 2019-05-13 13:22:51 PDT
Created attachment 369773 [details] EWS page showing ToT compile failure
Daniel Bates
Comment 3 2019-05-13 13:23:15 PDT
<https://ews-build.webkit.org/#/builders/13/builds/2052>
Aakash Jain
Comment 4 2019-05-13 13:26:21 PDT
Thanks for reporting the issue and sorry for the inconvenience caused. I haven't yet implemented the comparison with ToT in case of build failure. I will try to implement it soon.
Aakash Jain
Comment 5 2019-06-19 21:05:53 PDT
This should be fixed with https://trac.webkit.org/changeset/246609/webkit
Note You need to log in before you can comment on or make changes to this bug.